Re: [PATCH 3/3] lm90: register with thermal zones

Rob Herring
2016-01-22T23:11:54Z

On Fri, Jan 22, 2016 at 5:02 PM, Stéphan Kochen <stephan-j6uo2F6POYhmR6Xm/wNWPw@public.gmane.org> wrote:
> On Fri, Jan 22, 2016 at 04:45:42PM -0600, Rob Herring wrote:
>> On Thu, Jan 21, 2016 at 08:34:37PM +0100, Stéphan Kochen wrote:
>> > +- #thermal-sensor-cells: Should be 1. See ../../thermal/thermal.txt for a
>> > + description of this property. Use the following
>> > + values to refer to a specific sensor:
>> > + 0: chip internal sensor
>> > + 1: external sensor
>> > + 2: second external sensor, if present
>>
>> From my read of an LM90 datasheet, there is only an onchip sensor and a
>> single external one.
>
> MAX6695 and MAX6696 have two external sensors, and also use the lm90
> driver. (The LM90_HAVE_TEMP3 flag in the code.)

Okay.

This change alone seems fine, but I agree with Guenter's comments. I
think having the data in DT is fine, but it should be something
common.

Rob