From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Date: Mon, 25 Jan 2016 12:49:38 +0000 Message-ID: <20160125124938.GL3368@x1> References: <1453445087-2791-1-git-send-email-wenyou.yang@atmel.com> <1453445087-2791-2-git-send-email-wenyou.yang@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1453445087-2791-2-git-send-email-wenyou.yang@atmel.com> Sender: linux-kernel-owner@vger.kernel.org To: Wenyou Yang Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Javier Martinez Canillas , Krzysztof Kozlowski , Peter Korsgaard , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, 22 Jan 2016, Wenyou Yang wrote: > This patch adds support for the Active-semi ACT8945A PMIC. > It is a Multi Function Device with the following subdevices: > - Regulator > - Charger >=20 > It is interfaced to the host controller using I2C interface, > ACT8945A is a child device of the I2C. >=20 > Signed-off-by: Wenyou Yang > Reviewed-by: Krzysztof Kozlowski > --- >=20 > Changes in v7: > - remove struct act8945a_dev to .c file. > - remove unused .h file. >=20 > Changes in v6: > - change MFD_ACT8945A type from bool to tristate. > - revert depends on to 'I2C'. >=20 > Changes in v5: > - change depends on to 'I2C=3Dy'. >=20 > Changes in v4: > - add a space before .compatible. > - collect Reviewed-by from Krzysztof Kozlowski. >=20 > Changes in v3: None > Changes in v2: > - add more help information in Kconfig. > - update the file header with short version license and author line. > - remove unused structure members (dev, i2c_client) of stuct act8945= a_dev. > - use define "PLATFORM_DEVID_NONE" for mfd_add_devices(), instead of= '-1'. > - use more explicit info to indicate the failure to add sub devices. > - remove the unnecessary print out. > - substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2"). >=20 > drivers/mfd/Kconfig | 11 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/act8945a.c | 112 ++++++++++++++++++++++++++++++++++++++= ++++++++++ > 3 files changed, 124 insertions(+) > create mode 100644 drivers/mfd/act8945a.c >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 9ca66de..5038e78 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -18,6 +18,17 @@ config MFD_CS5535 > This is the core driver for CS5535/CS5536 MFD functions. This is > necessary for using the board's GPIO and MFGPT functionali= ty. > =20 > +config MFD_ACT8945A > + tristate "Active-semi ACT8945A" > + select MFD_CORE > + select REGMAP_I2C > + depends on I2C && OF > + help > + Support for the ACT8945A PMIC from Active-semi. This device > + features three step-down DC/DC converters and four low-dropout > + linear regulators, along with a complete ActivePath battery > + charger. > + > config MFD_AS3711 > bool "AMS AS3711" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 0f230a6..2f1ca82 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -6,6 +6,7 @@ > obj-$(CONFIG_MFD_88PM860X) +=3D 88pm860x.o > obj-$(CONFIG_MFD_88PM800) +=3D 88pm800.o 88pm80x.o > obj-$(CONFIG_MFD_88PM805) +=3D 88pm805.o 88pm80x.o > +obj-$(CONFIG_MFD_ACT8945A) +=3D act8945a.o > obj-$(CONFIG_MFD_SM501) +=3D sm501.o > obj-$(CONFIG_MFD_ASIC3) +=3D asic3.o tmio_core.o > obj-$(CONFIG_MFD_BCM590XX) +=3D bcm590xx.o > diff --git a/drivers/mfd/act8945a.c b/drivers/mfd/act8945a.c > new file mode 100644 > index 0000000..d2e01941 > --- /dev/null > +++ b/drivers/mfd/act8945a.c > @@ -0,0 +1,112 @@ > +/* > + * MFD driver for Active-semi ACT8945a PMIC > + * > + * Copyright (C) 2015 Atmel Corporation. > + * > + * Author: Wenyou Yang > + * > + * This program is free software; you can redistribute it and/or mod= ify it > + * under the terms of the GNU General Public License as published = by the > + * Free Software Foundation; either version 2 of the License, or (a= t your > + * option) any later version. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +struct act8945a_dev { > + struct regmap *regmap; > +}; > + > +static const struct mfd_cell act8945a_devs[] =3D { > + { > + .name =3D "act8945a-pmic", I think this should be -regulator, rather than -pmic. I believe *this* is the PMIC driver. > + .of_compatible =3D "active-semi,act8945a-regulator", > + }, > + { > + .name =3D "act8945a-charger", > + .of_compatible =3D "active-semi,act8945a-charger", > + }, > +}; > + > +static const struct regmap_config act8945a_regmap_config =3D { > + .reg_bits =3D 8, > + .val_bits =3D 8, > +}; > + > +static int act8945a_i2c_probe(struct i2c_client *i2c, > + const struct i2c_device_id *id) > +{ > + struct act8945a_dev *act8945a; > + int ret; > + > + act8945a =3D devm_kzalloc(&i2c->dev, sizeof(*act8945a), GFP_KERNEL)= ; > + if (!act8945a) > + return -ENOMEM; > + > + i2c_set_clientdata(i2c, act8945a); > + > + act8945a->regmap =3D devm_regmap_init_i2c(i2c, &act8945a_regmap_con= fig); > + if (IS_ERR(act8945a->regmap)) { > + ret =3D PTR_ERR(act8945a->regmap); > + dev_err(&i2c->dev, "regmap init failed: %d\n", ret); > + return ret; > + } Is the Regmap used in both the charger AND regulator drivers? > + ret =3D mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE, act8945a_de= vs, > + ARRAY_SIZE(act8945a_devs), NULL, 0, NULL); > + if (ret) { > + dev_err(&i2c->dev, "Failed to add sub devices\n"); > + return ret; > + } > + > + return 0; > +} > + > +static int act8945a_i2c_remove(struct i2c_client *i2c) > +{ > + mfd_remove_devices(&i2c->dev); > + > + return 0; > +} > + > +static const struct i2c_device_id act8945a_i2c_id[] =3D { > + { "act8945a", 0 }, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, act8945a_i2c_id); > + > +static const struct of_device_id act8945a_of_match[] =3D { > + { .compatible =3D "active-semi,act8945a", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, act8945a_of_match); > + > +static struct i2c_driver act8945a_i2c_driver =3D { > + .driver =3D { > + .name =3D "act8945a", > + .of_match_table =3D of_match_ptr(act8945a_of_match), > + }, > + .probe =3D act8945a_i2c_probe, > + .remove =3D act8945a_i2c_remove, > + .id_table =3D act8945a_i2c_id, > +}; > + > +static int __init act8945a_i2c_init(void) > +{ > + return i2c_add_driver(&act8945a_i2c_driver); > +} > +subsys_initcall(act8945a_i2c_init); > + > +static void __exit act8945a_i2c_exit(void) > +{ > + i2c_del_driver(&act8945a_i2c_driver); > +} > +module_exit(act8945a_i2c_exit); > + > +MODULE_DESCRIPTION("ACT8945A PMIC multi-function driver"); > +MODULE_AUTHOR("Wenyou Yang "); > +MODULE_LICENSE("GPL"); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog