From: Mark Brown <broonie@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Tony Lindgren" <tony@atomide.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional
Date: Mon, 25 Jan 2016 13:52:20 +0000 [thread overview]
Message-ID: <20160125135220.GR6588@sirena.org.uk> (raw)
In-Reply-To: <20160125135109.760ba5f0@ipc1.ka-ro>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Mon, Jan 25, 2016 at 01:51:09PM +0100, Lothar Waßmann wrote:
> On Mon, 25 Jan 2016 12:41:23 +0000 Mark Brown wrote:
> > The above, for example - make the interrupt optional.
> This will make it impossible to notify the system about
> overtemperature (and undervoltage).
> I implemented polling to be able to get at least overtemperature
> warnings.
> (Undervoltage cannot be handled sensibly without interrupt anyway)
I'm not convinced that justifies constantly polling, if the system
designers cared you'd hope they'd have wired it up to a working
interrupt. People commonly don't, realistically thermal warnings are
usually set near the point where the silicon will be physically damaged
and typically by the time they fire the system is already experiencing
catastrophic problems at a system level.
The polling is at the very least a separate change, and making the
interrupt work would be a much better option.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-25 13:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 12:29 PATCH [0/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann
2016-01-20 12:29 ` [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann
[not found] ` <1453292992-1788-2-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2016-01-20 16:42 ` Mark Brown
2016-01-21 7:05 ` Lothar Waßmann
[not found] ` <20160121080524.27af489f-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2016-01-21 10:20 ` Mark Brown
2016-01-21 10:26 ` Lothar Waßmann
[not found] ` <20160121112611.34e17cb2-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2016-01-21 11:11 ` Mark Brown
[not found] ` <20160121111115.GJ6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-21 11:33 ` Lothar Waßmann
[not found] ` <20160121123311.5346e40d-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2016-01-21 16:26 ` Mark Brown
2016-01-22 5:41 ` Lothar Waßmann
2016-01-22 16:26 ` Mark Brown
[not found] ` <20160122162610.GZ6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-25 12:37 ` Lothar Waßmann
[not found] ` <20160125133731.72669115-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2016-01-25 12:41 ` Mark Brown
2016-01-25 12:51 ` Lothar Waßmann
2016-01-25 13:52 ` Mark Brown [this message]
2016-01-20 17:29 ` Grygorii Strashko
2016-01-20 12:29 ` [PATCH 2/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann
2016-01-20 16:32 ` Robert Nelson
2016-02-12 22:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125135220.GR6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=LW@KARO-electronics.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).