devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] ARM64: tegra: Add chosen node for tegra132 norrin
@ 2016-01-25 15:55 Jon Hunter
       [not found] ` <1453737310-11391-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2016-01-25 15:55 UTC (permalink / raw)
  To: arm-u79uwXL29TY76Z2rM5mHXA
  Cc: Thierry Reding, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA, Jon Hunter

The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
in the device-tree blob and if it is not then it fails to boot the kernel.
Add the chosen node so we can boot the kernel on Tegra132 Norrin with the
nvtboot bootloader.

Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Ideally, we would like to get this into v4.5 as a fix for Tegra132 Norrin
so that we can enable booting this board as part of our automated testing
setup for Tegra [0][1]. Thierry suggested I send this directly as a fix
to ARM-SOC. Let me know if this is ok. I have not included a "fixes" as it
may not be needed for all bootloaders, but if you need this we could put:

Fixes: 0f279eb arm64: tegra: Add NVIDIA Tegra132 Norrin support

[0] http://nvtb.github.io/linux/
[1] http://nvtb.github.io/linux-next/

 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
index 7dfe1c085966..62f33fc84e3e 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
@@ -12,6 +12,8 @@
 		rtc1 = "/rtc@0,7000e000";
 	};
 
+	chosen { };
+
 	memory {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x0 0x80000000>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM64: tegra: Add chosen node for tegra132 norrin
       [not found] ` <1453737310-11391-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2016-01-25 15:57   ` Jon Hunter
       [not found]     ` <56A645CC.5070907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2016-01-25 15:57 UTC (permalink / raw)
  To: arm-u79uwXL29TY76Z2rM5mHXA
  Cc: Thierry Reding, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA


On 25/01/16 15:55, Jon Hunter wrote:
> The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
> in the device-tree blob and if it is not then it fails to boot the kernel.
> Add the chosen node so we can boot the kernel on Tegra132 Norrin with the
> nvtboot bootloader.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Ideally, we would like to get this into v4.5 as a fix for Tegra132 Norrin
> so that we can enable booting this board as part of our automated testing
> setup for Tegra [0][1]. Thierry suggested I send this directly as a fix
> to ARM-SOC. Let me know if this is ok. I have not included a "fixes" as it
> may not be needed for all bootloaders, but if you need this we could put:
> 
> Fixes: 0f279eb arm64: tegra: Add NVIDIA Tegra132 Norrin support
> 
> [0] http://nvtb.github.io/linux/
> [1] http://nvtb.github.io/linux-next/

Forgot to mentioned that the differences for v1 -> v2 are just some
minor corrections to the commit message.

Jon

>  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> index 7dfe1c085966..62f33fc84e3e 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> @@ -12,6 +12,8 @@
>  		rtc1 = "/rtc@0,7000e000";
>  	};
>  
> +	chosen { };
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0x0 0x80000000 0x0 0x80000000>;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM64: tegra: Add chosen node for tegra132 norrin
       [not found]     ` <56A645CC.5070907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2016-01-25 16:01       ` Jon Hunter
       [not found]         ` <56A646BC.1010708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2016-01-25 16:01 UTC (permalink / raw)
  To: arm-DgEjT+Ai2ygdnm+yROfE0A
  Cc: Thierry Reding, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

Correcting ARM-SOC email address ..

On 25/01/16 15:57, Jon Hunter wrote:
> 
> On 25/01/16 15:55, Jon Hunter wrote:
>> The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
>> in the device-tree blob and if it is not then it fails to boot the kernel.
>> Add the chosen node so we can boot the kernel on Tegra132 Norrin with the
>> nvtboot bootloader.
>>
>> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> Ideally, we would like to get this into v4.5 as a fix for Tegra132 Norrin
>> so that we can enable booting this board as part of our automated testing
>> setup for Tegra [0][1]. Thierry suggested I send this directly as a fix
>> to ARM-SOC. Let me know if this is ok. I have not included a "fixes" as it
>> may not be needed for all bootloaders, but if you need this we could put:
>>
>> Fixes: 0f279eb arm64: tegra: Add NVIDIA Tegra132 Norrin support
>>
>> [0] http://nvtb.github.io/linux/
>> [1] http://nvtb.github.io/linux-next/
> 
> Forgot to mentioned that the differences for v1 -> v2 are just some
> minor corrections to the commit message.
> 
> Jon
> 
>>  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> index 7dfe1c085966..62f33fc84e3e 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
>> @@ -12,6 +12,8 @@
>>  		rtc1 = "/rtc@0,7000e000";
>>  	};
>>  
>> +	chosen { };
>> +
>>  	memory {
>>  		device_type = "memory";
>>  		reg = <0x0 0x80000000 0x0 0x80000000>;
>>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM64: tegra: Add chosen node for tegra132 norrin
       [not found]         ` <56A646BC.1010708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2016-01-25 17:10           ` Thierry Reding
  0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-01-25 17:10 UTC (permalink / raw)
  To: Jon Hunter
  Cc: arm-DgEjT+Ai2ygdnm+yROfE0A,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]

On Mon, Jan 25, 2016 at 04:01:00PM +0000, Jon Hunter wrote:
> Correcting ARM-SOC email address ..

You might have to resend so that the original patch shows up in the
ARM SoC maintainers' inbox.

Thierry

> On 25/01/16 15:57, Jon Hunter wrote:
> > 
> > On 25/01/16 15:55, Jon Hunter wrote:
> >> The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
> >> in the device-tree blob and if it is not then it fails to boot the kernel.
> >> Add the chosen node so we can boot the kernel on Tegra132 Norrin with the
> >> nvtboot bootloader.
> >>
> >> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> ---
> >> Ideally, we would like to get this into v4.5 as a fix for Tegra132 Norrin
> >> so that we can enable booting this board as part of our automated testing
> >> setup for Tegra [0][1]. Thierry suggested I send this directly as a fix
> >> to ARM-SOC. Let me know if this is ok. I have not included a "fixes" as it
> >> may not be needed for all bootloaders, but if you need this we could put:
> >>
> >> Fixes: 0f279eb arm64: tegra: Add NVIDIA Tegra132 Norrin support
> >>
> >> [0] http://nvtb.github.io/linux/
> >> [1] http://nvtb.github.io/linux-next/
> > 
> > Forgot to mentioned that the differences for v1 -> v2 are just some
> > minor corrections to the commit message.
> > 
> > Jon
> > 
> >>  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> >> index 7dfe1c085966..62f33fc84e3e 100644
> >> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> >> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> >> @@ -12,6 +12,8 @@
> >>  		rtc1 = "/rtc@0,7000e000";
> >>  	};
> >>  
> >> +	chosen { };
> >> +
> >>  	memory {
> >>  		device_type = "memory";
> >>  		reg = <0x0 0x80000000 0x0 0x80000000>;
> >>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-01-25 17:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 15:55 [PATCH V2] ARM64: tegra: Add chosen node for tegra132 norrin Jon Hunter
     [not found] ` <1453737310-11391-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-25 15:57   ` Jon Hunter
     [not found]     ` <56A645CC.5070907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-25 16:01       ` Jon Hunter
     [not found]         ` <56A646BC.1010708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-25 17:10           ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).