devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: kbuild-all@01.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
	Martyn Welch <martyn.welch@collabora.com>
Subject: Re: [PATCH 2/2] power: ucs1002: Add support for Programmable USB Port Power Controller
Date: Tue, 26 Jan 2016 21:10:38 +0800	[thread overview]
Message-ID: <201601262113.QMsv6ZED%fengguang.wu@intel.com> (raw)
In-Reply-To: <1453799541-5445-3-git-send-email-enric.balletbo@collabora.com>

Hi Enric,

[auto build test WARNING on battery/master]
[also build test WARNING on v4.5-rc1 next-20160125]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-UCS1002-USB-Port-Power-Controller/20160126-171717
base:   git://git.infradead.org/battery-2.6.git master


coccinelle warnings: (new ones prefixed by >>)

>> drivers/power/ucs1002_power.c:203:40-49: ERROR: info -> pdata is NULL but dereferenced.

vim +203 drivers/power/ucs1002_power.c

   187		/* Read the polarity setting determined by the SEL pin */
   188		ret = regmap_read(info->regmap, UCS1002_REG_PIN_STATUS, &regval);
   189		if (ret < 0)
   190			return ret;
   191	
   192		if (regval & F_SEL_PIN)
   193			val = enable ? F_PWR_EN_SET : 0;
   194		else
   195			val = enable ? 0 : F_PWR_EN_SET;
   196	
   197		if (info->pdata) {
   198			ret = regmap_update_bits(info->regmap, UCS1002_REG_SWITCH_CFG,
   199						 F_PWR_EN_SET, val);
   200			if (ret < 0)
   201				return ret;
   202		} else {
 > 203			gpiod_set_value_cansleep(info->pdata->gpiod_pwr, val ? 0 : 1);
   204		}
   205	
   206		info->enabled = enable;
   207	
   208		return 0;
   209	}
   210	
   211	static int ucs1002_get_online(struct ucs1002_info *info,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

  reply	other threads:[~2016-01-26 13:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  9:12 [PATCH 0/2] Add UCS1002 USB Port Power Controller Enric Balletbo i Serra
2016-01-26  9:12 ` [PATCH 1/2] devicetree: Add UCS1002 USB Port Power Controller binding Enric Balletbo i Serra
2016-01-29  2:35   ` Rob Herring
2016-01-29  6:33     ` Enric Balletbo Serra
2016-01-26  9:12 ` [PATCH 2/2] power: ucs1002: Add support for Programmable USB Port Power Controller Enric Balletbo i Serra
2016-01-26 13:10   ` kbuild test robot [this message]
     [not found]   ` <1453799541-5445-3-git-send-email-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2016-02-08 12:38     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601262113.QMsv6ZED%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=enric.balletbo@collabora.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martyn.welch@collabora.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sjoerd.simons@collabora.co.uk \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).