From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024 Date: Wed, 27 Jan 2016 07:24:30 +0000 Message-ID: <20160127072430.GD3368@x1> References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-2-git-send-email-ldewangan@nvidia.com> <20160125115610.GC3368@x1> <56A63A85.6060609@nvidia.com> <20160126145854.GC3368@x1> <56A79DB4.6090000@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <56A79DB4.6090000@nvidia.com> Sender: linux-gpio-owner@vger.kernel.org To: Laxman Dewangan Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com, vreddytalla@nvidia.com List-Id: devicetree@vger.kernel.org On Tue, 26 Jan 2016, Laxman Dewangan wrote: >=20 > On Tuesday 26 January 2016 08:28 PM, Lee Jones wrote: > >On Mon, 25 Jan 2016, Laxman Dewangan wrote: > > > >>Hmm. I describe the boolean and tristate only. Do I need to define > >>type for integer,string also? > >I wouldn't describe any of them. It's normally pretty obvious which > >properties are boolean by the lack of required cell description. > > >=20 > Rob suggested to use the type also for Boolean and tristate. I think > it is good to have for all places that what type of values are > valid. It's fine, and some people do describe them. I've just never seen the point, especially if you have a nice example of their use in the document. But if you insist, please ensure you are consistent, so *all* bools need to be described. That is not currently the case. > >>>>+The property for fps child nodes as: > >>>>+Required properties: > >>>>+ -reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectiv= ely. > >>>I'm surprised Rob Acked this. We don't usually do device numbers = in DT. > >>What is best way to make the child node for FPS and differentiate F= PS0,1, 2? > >>What is your suggestion here? > >There are lots of ways you can solve this and so many examples of > >others doing so. I suggest you have a look at some DTS files and > >figure it out. One possible solution is to use different compatible > >strings. > Here, I think I can go similar to regulators where child node name > identifies the regulators. >=20 > fps-config { > fps0 { > maxim,fps-time-period-us =3D <1280>; > maxim,fps-enable-input =3D ; > }; >=20 > fps1 { > maxim,fps-time-period-us =3D <2560>; > maxim,fps-enable-input =3D ; > }; >=20 > fps2 { > maxim,fps-time-period-us =3D <640>; > maxim,fps-enable-input =3D ; > }; > }; >=20 > So node name gives the FPS name. That is also an acceptable means to solve the issue. As I said, there are many ways to skin a cat. > >>>+Pinmux and GPIO: > >>>+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >>>I think this whole section needs moving to ../pinctrl and needs to= be > >>>reviewed by Linus W. > >>Is this mean I need to create DT binding doc for the each subsystem > >>differently? > >>Actually during AS3722, I had different understanding to have singl= e file. > >Yes, that way you have each of the the subsystem experts review your > >documentation. You can then link to them from this document. > OK, I will add different dt binding doc in respective driver and > squash that with respected submodule drivers. >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html