From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
James Hartley <james.hartley@imgtec.com>
Subject: Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card
Date: Wed, 27 Jan 2016 14:57:56 +0000 [thread overview]
Message-ID: <20160127145756.GR6042@sirena.org.uk> (raw)
In-Reply-To: <1453818867-16322-2-git-send-email-Damien.Horsley@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Tue, Jan 26, 2016 at 02:34:26PM +0000, Damien Horsley wrote:
> + - clock-names : Includes the following entries:
> + "audio_pll" The audio PLL
> + "i2s_mclk" The i2s reference clock
> + Also connected to i2s_out_0_mclk output
> + "dac_mclk" Dac reference clock. Connected to i2s_dac_clk output
Why are these (especially the dac_mclk and i2s_mclk) properties of the
card and not of the drivers for the respective devices?
> + - img,mute-gpio : phandle of the mute gpio
> +
> + - img,hp-det-gpio : phandle of the headphone detect gpio
The DT maintainers would prefer those to be named -gpios.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-27 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 14:34 [RFC V2 0/2] ASoC: img: Add Pistachio card support Damien Horsley
2016-01-26 14:34 ` [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card Damien Horsley
2016-01-27 14:57 ` Mark Brown [this message]
2016-01-27 15:18 ` Damien Horsley
2016-01-27 16:00 ` Mark Brown
[not found] ` <20160127160057.GA25316-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-27 17:13 ` Damien Horsley
2016-01-27 20:14 ` Mark Brown
2016-01-28 14:17 ` Damien Horsley
2016-01-28 23:25 ` Mark Brown
2016-01-26 14:34 ` [RFC V2 2/2] ASoC: img: Add driver " Damien Horsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127145756.GR6042@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Damien.Horsley@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.hartley@imgtec.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).