* [PATCH] ARM: dts: am4372: fix irq type for arm twd and global timer
@ 2015-12-28 13:52 Grygorii Strashko
[not found] ` <1451310724-29454-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Grygorii Strashko @ 2015-12-28 13:52 UTC (permalink / raw)
To: tony-4v6yS6AI5VpBDgjK7y7TUQ
Cc: nsekhar-l0cyMroinI0, jonathanh-DDmLM1+adcrQT0dZR+AlfA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Grygorii Strashko
As per ARM documentation
PPI(0) ID27 - global timer interrupt is rising-edge sensitive.
PPI(2) ID29 - twd interrupt is rising-edge sensitive.
and the same is proved by GIC distributor register value
GIC_DIST_CONFIG(0xC04) = 0x7DC00000.
Hence, set IRQ triggering type to IRQ_TYPE_EDGE_RISING
for ARM TWD and Global timers.
Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/am4372.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index de8791a..dfa1a29 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -72,7 +72,7 @@
global_timer: timer@48240200 {
compatible = "arm,cortex-a9-global-timer";
reg = <0x48240200 0x100>;
- interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>;
interrupt-parent = <&gic>;
clocks = <&mpu_periphclk>;
};
@@ -80,7 +80,7 @@
local_timer: timer@48240600 {
compatible = "arm,cortex-a9-twd-timer";
reg = <0x48240600 0x100>;
- interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_PPI 13 IRQ_TYPE_EDGE_RISING>;
interrupt-parent = <&gic>;
clocks = <&mpu_periphclk>;
};
--
2.6.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: am4372: fix irq type for arm twd and global timer
[not found] ` <1451310724-29454-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
@ 2016-01-27 16:47 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2016-01-27 16:47 UTC (permalink / raw)
To: Grygorii Strashko
Cc: nsekhar-l0cyMroinI0, jonathanh-DDmLM1+adcrQT0dZR+AlfA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
* Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [151228 05:52]:
> As per ARM documentation
> PPI(0) ID27 - global timer interrupt is rising-edge sensitive.
> PPI(2) ID29 - twd interrupt is rising-edge sensitive.
>
> and the same is proved by GIC distributor register value
> GIC_DIST_CONFIG(0xC04) = 0x7DC00000.
>
> Hence, set IRQ triggering type to IRQ_TYPE_EDGE_RISING
> for ARM TWD and Global timers.
Applying into omap-for-v4.5/fixes thanks.
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-27 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-28 13:52 [PATCH] ARM: dts: am4372: fix irq type for arm twd and global timer Grygorii Strashko
[not found] ` <1451310724-29454-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-01-27 16:47 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).