From: Sebastian Reichel <sre@kernel.org>
To: "Tony Lindgren" <tony@atomide.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Paul Walmsley" <paul@pwsan.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] HSI: ssi-protocol: Use handshake logic from n950
Date: Thu, 28 Jan 2016 17:54:16 +0100 [thread overview]
Message-ID: <20160128165415.GC17038@earth> (raw)
In-Reply-To: <1453045749-22642-5-git-send-email-sre@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]
Hi,
On Sun, Jan 17, 2016 at 04:49:08PM +0100, Sebastian Reichel wrote:
> When using the ssi-protocol driver with the Nokia N950, the
> following error is thrown during modem powered up sequence.
>
> [13852.274993] port0: SSI error: 0x01
> [13852.279205] ssi-protocol ssi-protocol: RX error detected
> [13852.284820] ssi-protocol ssi-protocol: Main state: 1
> [13852.290069] ssi-protocol ssi-protocol: Recv state: 0
> [13852.295288] ssi-protocol ssi-protocol: Send state: 0
> [13852.300537] ssi-protocol ssi-protocol: CMT Offline
> [13852.305603] ssi-protocol ssi-protocol: Wake test 1
> [13852.310638] ssi-protocol ssi-protocol: Data RX id: 0
> [13852.315887] ssi-protocol ssi-protocol: Data TX id: 0
> [13856.001464] ssi-protocol ssi-protocol: Watchdog trigerred
> [13856.007293] ssi-protocol ssi-protocol: Main state: 1
> [13856.012542] ssi-protocol ssi-protocol: Recv state: 0
> [13856.017761] ssi-protocol ssi-protocol: Send state: 0
> [13856.023010] ssi-protocol ssi-protocol: CMT Offline
> [13856.028045] ssi-protocol ssi-protocol: Wake test 0
> [13856.033111] ssi-protocol ssi-protocol: Data RX id: 0
> [13856.038330] ssi-protocol ssi-protocol: Data TX id: 0
>
> This patch fixes the issue by using the handshake setup from
> the Nokia N950 kernel. The new handshake sequence also works
> with the N900, so there is no need to differentiate between
> both modems.
I queued this patch with Aaro's Tested-By:
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=87d99063be016ceee90723a13365a40b21eec0d9
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-28 16:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 15:49 [PATCH 0/5] Nokia N950 modem support Sebastian Reichel
[not found] ` <1453045749-22642-1-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-01-17 15:49 ` [PATCH 1/5] ARM: OMAP2+: hwmod data: Add SSI data for omap36xx Sebastian Reichel
2016-01-26 22:07 ` Aaro Koskinen
2016-01-26 22:12 ` Aaro Koskinen
[not found] ` <20160126220738.GG15550-4/PLUo9XfK9owWHViPbQSXlKr5M7+etX9Sl0XMgJPXI@public.gmane.org>
2016-02-02 17:05 ` Paul Walmsley
2016-01-17 15:49 ` [PATCH 2/5] ARM: dts: OMAP3-N950-N9: Enable SSI module Sebastian Reichel
2016-02-12 22:00 ` Tony Lindgren
2016-01-17 15:49 ` [PATCH 3/5] HSI: nokia-modem: add n950 and n9 support Sebastian Reichel
2016-01-20 16:49 ` Rob Herring
2016-01-21 12:30 ` Sebastian Reichel
2016-01-28 16:53 ` Sebastian Reichel
2016-01-17 15:49 ` [PATCH 4/5] HSI: ssi-protocol: Use handshake logic from n950 Sebastian Reichel
2016-01-28 16:54 ` Sebastian Reichel [this message]
2016-01-17 15:49 ` [PATCH 5/5] ARM: dts: OMAP3-N950-N9: Enable modem Sebastian Reichel
[not found] ` <1453045749-22642-6-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-02-12 22:01 ` Tony Lindgren
2016-01-28 17:04 ` [PATCH 0/5] Nokia N950 modem support Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128165415.GC17038@earth \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).