Re: [PATCH 4/4] drm/layerscape: Add HDMI driver for freescale DCU

[Rob Herring <robh@kernel.org>]

On Tue, Jan 26, 2016 at 12:00:33PM +0800, Meng Yi wrote:
> DCU is the shortcut of 'display controller unit', some HDMI transmitter
> attached to DCU, such as sii9022a, and this driver add the relavent
> functions to DRM framewrok.
> 
> Signed-off-by: Meng Yi <meng.yi@nxp.com>
> ---
>  .../bindings/display/bridge/sil,sii9022a.txt       |  40 +++
>  drivers/gpu/drm/fsl-dcu/Makefile                   |   1 +
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h          |   1 +
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_hdmi.c         | 271 +++++++++++++++++++++
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c          |  10 +
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_output.h       |  11 +
>  6 files changed, 334 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii9022a.txt
>  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_hdmi.c
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii9022a.txt b/Documentation/devicetree/bindings/display/bridge/sil,sii9022a.txt
> new file mode 100644
> index 0000000..32a726a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii9022a.txt
> @@ -0,0 +1,40 @@
> +Device-Tree bindings for the SiI902x hdmi transmitter.
> +-----------------------------------------
> +
> +The SiI9022A is an ultra low-power HDMI transmitter. It supports resolutions from
> +standard definition 480i/p and 576i/p all the way to high-definition 720p, 1080i,
> +and 1080p, the highest resolution supported by HDTVs today. It also supports all

Well, we're up to 4K now...

> +PC resolutions up to UXGA for netbooks
> +
> +Required properties:
> +- compatible: 	Should be "sil,sii9022a".
> +- reg: 		The I2C address of the device.
> +- interrupts:	Interrupt number to the cpu.
> +
> +Required nodes:
> +
> +The sii9022 has one video ports. Its connection is modelled using the OF
> +graph bindings specified in Documentation/devicetree/bindings/graph.txt.
> +
> +- Video port 0 for the HDMI output
> +
> +Example:
> +-------
> +
> +    sii9022: hdmi@39 {
> +            compatible = "sil,sii9022a";
> +            reg = <0x39>;
> +            interrupts = <GIC_SPI 167 IRQ_TYPE_EDGE_RISING>;
> +
> +            ports {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +
> +                    port@0 {
> +                            reg = <1>;

Your unit address (0) and reg don't match.

> +                            sii9022_out: endpoint {
> +                                    remote-endpoint = <&hdmi_con>;
> +                            };

This needs to have a port for the input for the connection to your 
display controller.

> +                    };
> +            };
> +    };
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel