devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Suman Tripathi <stripathi@apm.com>
Cc: olof@lixom.net, arnd@arndb.de, linux-ide@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	mlangsdo@redhat.com, jcm@redhat.com, patches@apm.com,
	svtripathi@gmail.com
Subject: Re: [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci.
Date: Sun, 31 Jan 2016 06:32:49 -0500	[thread overview]
Message-ID: <20160131113249.GW32380@htj.duckdns.org> (raw)
In-Reply-To: <1453888197-11368-2-git-send-email-stripathi@apm.com>

On Wed, Jan 27, 2016 at 03:19:55PM +0530, Suman Tripathi wrote:
> This patch removes the AHCI_HFLAG_EDGE_IRQ support from libahci.
> The upcoming patches will have the flexibility to override
> irq handlers in the LLD's. Controller's implementing a EDGE trigger
> latch can implement their own interrupt handler inside the driver.
> 
> Signed-off-by: Suman Tripathi <stripathi@apm.com>

Shouldn't this patch come after the irq override is in place?

1. introduce irq override.

2. remove AHCI_HFLAG_EDGE_IRQ by moving the edge triggered handler to
   ahci_xgene.

3. Update xgene irq handler to address the erratum.

Thanks.

-- 
tejun

  reply	other threads:[~2016-01-31 11:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27  9:49 [PATCH v2 0/3] ata: Fixes related to edge trigger latch for ahci_xgene driver Suman Tripathi
     [not found] ` <1453888197-11368-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2016-01-27  9:49   ` [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci Suman Tripathi
2016-01-31 11:32     ` Tejun Heo [this message]
2016-02-01 19:45       ` Suman Tripathi
2016-01-27  9:49   ` [PATCH v2 2/3] libahci: Implement the capability to override the generic ahci interrupt handler Suman Tripathi
     [not found]     ` <1453888197-11368-3-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2016-01-31 11:35       ` Tejun Heo
2016-02-01 19:43         ` Suman Tripathi
2016-01-27  9:49   ` [PATCH v2 3/3] ahci_xgene: Implement the workaround to fix the missing of edge interrupt for HOST_IRQ_STAT Suman Tripathi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160131113249.GW32380@htj.duckdns.org \
    --to=htejun@gmail.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mlangsdo@redhat.com \
    --cc=olof@lixom.net \
    --cc=patches@apm.com \
    --cc=stripathi@apm.com \
    --cc=svtripathi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).