Re: [PATCH v4 2/2] rtc: add driver for RX6110SA real time clock

[Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Sun, Jan 31, 2016 at 12:54:57PM +0100, Alexandre Belloni wrote:
> On 04/01/2016 at 18:04:35 +0100, Steffen Trumtrar wrote :
> > The RX6110 comes in two different variants: SPI and I2C.
> > This driver only supports the SPI variant.
> > 
> > If the need ever arises to also support the I2C variant, this driver
> > could easily be refactored to support both cases.
> > 
> > Reviewed-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> > 
> > Changes since v3:
> >     - remove old copyright infos
> >     - use the BIT() macro
> >     - replace rx6110_get_week_day() with ffs()
> >     - replace hardcoded offsets with enum
> >     - use regmap_bulk_write in set_time
> >     - use regmap_register_patch in init function
> >     - return -EINVAL instead of "fixing" time in the rtc
> > 
> >  drivers/rtc/Kconfig      |   9 ++
> >  drivers/rtc/Makefile     |   1 +
> >  drivers/rtc/rtc-rx6110.c | 402 +++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 412 insertions(+)
> >  create mode 100644 drivers/rtc/rtc-rx6110.c
> > 
> Applied, after realigning some lines in rx6110_probe().
> 

Thanks :-)

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html