Re: [PATCH resend] ARM: dts: sun7i: Add dts file for the lamobo-r1 board

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

Hi,

On Thu, Jan 28, 2016 at 08:49:24AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 27-01-16 20:47, Maxime Ripard wrote:
> >Hi Hans,
> >
> >On Wed, Jan 27, 2016 at 07:41:45PM +0100, Hans de Goede wrote:
> >>From: Jelle de Jong <jelledejong-OIcJOM8/mISwoUgIn9SVlA@public.gmane.org>
> >>
> >>The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such
> >>on the PCB, is meant as a A20 based router board. As such the board comes
> >>with a built-in switch chip giving it 5 gigabit ethernet boards, and it
> >>has a large empty area on the pcb with mounting holes which will fit a
> >>2.5 inch harddisk. To complete its networking features it has a
> >>Realtek RTL8192CU for WiFi 802.11 b/g/n.
> >>
> >>Signed-off-by: Jelle de Jong <jelledejong-OIcJOM8/mISwoUgIn9SVlA@public.gmane.org>
> >>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> >Sorry that I missed it :/
> >
> >It looks mostly fine, I just have a minor question / comment below.
> >
> >>+&cpu0 {
> >>+	cpu-supply = <&reg_dcdc2>;
> >>+	operating-points = <
> >>+		/* kHz	  uV */
> >>+		960000	1400000
> >>+		912000	1400000
> >>+		864000	1350000
> >>+		720000	1250000
> >>+		528000	1150000
> >>+		312000	1100000
> >>+		144000	1050000
> >>+		>;
> >>+};
> >
> >Have you used the default OPPs and it turned out to be unstable, or is
> >it just some copy / paste from the FEX file?
> 
> Just copy paste from the fex file, let me know if you want a new version with
> the opp-s removed.

Yeah, if it works, please do so.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]