From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V5 4/5] gpio: max77620: add gpio driver for MAX77620/MAX20024 Date: Mon, 1 Feb 2016 08:32:28 +0000 Message-ID: <20160201083228.GY3368@x1> References: <1453903808-29788-1-git-send-email-ldewangan@nvidia.com> <1453903808-29788-5-git-send-email-ldewangan@nvidia.com> <20160129163035.GA15053@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160129163035.GA15053@rob-hp-laptop> Sender: linux-gpio-owner@vger.kernel.org To: Rob Herring Cc: Laxman Dewangan , pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com, Chaitanya Bandi List-Id: devicetree@vger.kernel.org On Fri, 29 Jan 2016, Rob Herring wrote: > On Wed, Jan 27, 2016 at 07:40:07PM +0530, Laxman Dewangan wrote: > > MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO > > pins. It also supports interrupts from these pins. > >=20 > > Add GPIO driver for these pins to control via GPIO APIs. > >=20 > > Signed-off-by: Laxman Dewangan > > Signed-off-by: Chaitanya Bandi > > --- > > Changes from V1: > > - Use the gpiochip_add_data and get the chip data from core APIs. > > - Cleanups based on comment received on mfd/rtc. > > - Avoid duplication on error message. > >=20 > > Changes form V2: > > - Run coccicheck and checkpatch in strict mode for the alignment. > > - update based on api changes from core. > >=20 > > Changes from V3:=20 > > - Change all sys initcall to module driver. > > - change the max77620_read argument to unisgned int from u8. > >=20 > > Changes from V4:=20 > > - Added DT binding document as devicetree/bindings/gpio/gpio-max776= 20.txt > >=20 > > .../devicetree/bindings/gpio/gpio-max77620.txt | 25 ++ > > drivers/gpio/Kconfig | 9 + > > drivers/gpio/Makefile | 1 + > > drivers/gpio/gpio-max77620.c | 292 +++++++++= ++++++++++++ > > 4 files changed, 327 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-max= 77620.txt > > create mode 100644 drivers/gpio/gpio-max77620.c > >=20 > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-max77620.t= xt b/Documentation/devicetree/bindings/gpio/gpio-max77620.txt > > new file mode 100644 > > index 0000000..410e716 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/gpio-max77620.txt > > @@ -0,0 +1,25 @@ > > +GPIO driver for MAX77620 Power management IC from Maxim Semiconduc= tor. > > + > > +Device has 8 GPIO pins which can be configured as GPIO as well as = the > > +special IO functions. > > + > > +Required properties: > > +------------------- > > +- gpio-controller : Marks the device node as a gpio controller. > > +- #gpio-cells : Should be two. The first cell is the pin number = and > > + the second cell is used to specify the gpio polarity: > > + 0 =3D active high > > + 1 =3D active low > > +For more details, please refer generic GPIO DT binding document > > +. >=20 > I would just fold these 2 properties into the main max77620 document. As these are simple/generic options, I'm happy to support that. Also happy to support them staying in their own subsystem doc i.e. this one, for consistency. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html