Re: [PATCH V5 5/5] regulator: max77620: add regulator driver for max77620/max20024

Rob Herring
2016-02-01T13:54:26Z

On Wed, Jan 27, 2016 at 07:40:08PM +0530, Laxman Dewangan wrote:
> MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the
> multiple DCDC and LDOs. This supplies the power to different
> components of the system.
> Also these rails has configuration for ramp time, flexible
> power sequence, slew rate etc.
>
> Add regulator driver to access these rails via regulator APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
> ---
> Changes from V1:
> - Cleanup code based on comment received on mfd/rtc.
> - Avoid duplication on error message.
>
> Changes form V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - Refactor Regulator driver to use core API for DT parsing.
> - Update based on API changes.
>
> Changes from V3:
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
>
> Changes from V4:
> - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt
> - Detail out properties.
>
> .../bindings/regulator/regulator-max77620.txt | 163 ++++

Acked-by: Rob Herring <robh@kernel.org>

> drivers/regulator/Kconfig | 9 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/max77620-regulator.c | 844 +++++++++++++++++++++
> 4 files changed, 1017 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/regulator-max77620.txt
> create mode 100644 drivers/regulator/max77620-regulator.c