From: Rob Herring <robh@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: dmitry.torokhov@gmail.com, michael.hennerich@analog.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, realmz6@gmail.com, broonie@kernel.org,
jic23@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support
Date: Mon, 1 Feb 2016 09:13:05 -0600 [thread overview]
Message-ID: <20160201151305.GA9558@rob-hp-laptop> (raw)
In-Reply-To: <1454111295-5615-3-git-send-email-stefan@agner.ch>
On Fri, Jan 29, 2016 at 03:48:15PM -0800, Stefan Agner wrote:
> Add device tree support for the I2C and SPI variant of AD7879(-1).
> This allows to specify the touchscreen controller as a I2C client
> node or SPI slave device. Most of the options available in platform
> data are also available as device tree properties, the only exception
> being GPIO capabilities, which can not be activated through device
> tree currently.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Changes since v1:
> - Move device tree parsing to main driver file ad7879.c
> - Use common touchscreen_parse_properties for common properties
> - Use device_property_* API
> - Use struct ad7879 directly to store parsed values
> - Support SPI variant through device tree too (untested)
> - Add vendor prefix to vendor specific dt properties
>
> .../bindings/input/touchscreen/ad7879.txt | 53 ++++++++
Acked-by: Rob Herring <robh@kernel.org>
> drivers/input/touchscreen/ad7879-i2c.c | 10 ++
> drivers/input/touchscreen/ad7879-spi.c | 10 ++
> drivers/input/touchscreen/ad7879.c | 141 +++++++++++++--------
> 4 files changed, 160 insertions(+), 54 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ad7879.txt
next prev parent reply other threads:[~2016-02-01 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 23:48 [PATCH v2 1/3] input: touchscreen: ad7879: move header to platform_data directory Stefan Agner
2016-01-29 23:48 ` [PATCH v2 2/3] input: touchscreen: ad7879: fix default x/y axis assignment Stefan Agner
2016-01-29 23:48 ` [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support Stefan Agner
2016-02-01 15:13 ` Rob Herring [this message]
[not found] <201601301057.HOqi7vdd%fengguang.wu@intel.com>
2016-01-30 7:06 ` Julia Lawall
2016-02-02 22:35 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201151305.GA9558@rob-hp-laptop \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.hennerich@analog.com \
--cc=realmz6@gmail.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox