Re: [PATCH] iio: light: opt3001: Add device tree binding documentation

[Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>]

On Mon, Feb 01, 2016 at 09:18:48AM -0600, Rob Herring wrote:
> On Fri, Jan 29, 2016 at 01:03:00PM -0600, Andreas Dannenberg wrote:
> > Signed-off-by: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>
> > ---
> >  .../devicetree/bindings/iio/light/opt3001.txt      | 26 ++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> > new file mode 100644
> > index 0000000..55b9cb3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> > @@ -0,0 +1,26 @@
> > +* Texas Instruments OPT3001 Ambient Light Sensor
> > +
> > +The driver supports interrupt-driven and interrupt-less operation, depending
> > +on whether an interrupt property has been populated into the DT. Note that
> > +the optional generation of IIO events on rising/falling light threshold changes
> > +requires the use of interrupts. Without interrupts, only the simple reading
> > +of the current light value is supported through the IIO API.
> 
> Seems like you could poll and do the threshold changes in s/w. Anyway, 
> that's all irrelevant to the DT binding.

True that. The recent addition of polling mode to the driver did not
consider this use case so until somebody has a strong need for this and
adds the needed code at least we have this limitation documented.

Regards,
Andreas


> 
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>