From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Date: Wed, 3 Feb 2016 23:02:24 +0100 Message-ID: <20160203230224.5ea52f65@free-electrons.com> References: <1454524889-9207-1-git-send-email-gregory.clement@free-electrons.com> <1454524889-9207-4-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-ide-owner@vger.kernel.org To: Marcin Wojtas Cc: Gregory CLEMENT , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , arm@kernel.org, Catalin Marinas , Will Deacon , Jonathan Corbet , Mark Rutland , "devicetree@vger.kernel.org" , linux-ide@vger.kernel.org, Greg Kroah-Hartman , Omri Itach , linux-kernel@vger.kernel.org, Nadav Haklai , Hans de Goede , Lior Amsalem , linux-serial@vger.kernel.org, Jiri Slaby , Tejun Heo , Wilson Ding , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Dear Marcin Wojtas, On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote: > Hi Gregory, > > > + port->irq = irq->start; > > + port->irqflags = 0; > > Same request as for v1, which you must have overlooked: > port->irqflags = IRQF_SHARED; Gregory didn't overlook this comment you made on v1, he even replied to it. Please check Gregory's reply to your review. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com