From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 04/14] clk: sunxi: add ahb1 clock for A83T Date: Thu, 4 Feb 2016 09:01:09 +0100 Message-ID: <20160204080109.GA4270@lukather> References: <1454203266-4450-1-git-send-email-vishnupatekar0510@gmail.com> <1454203266-4450-5-git-send-email-vishnupatekar0510@gmail.com> <20160202131725.GQ4652@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Vishnu Patekar Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Jonathan Corbet , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Kumar Gala , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , Emilio Lopez , Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , Michael Turquette , Stephen Boyd , Reinde List-Id: devicetree@vger.kernel.org --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Thu, Feb 04, 2016 at 02:06:45PM +0800, Vishnu Patekar wrote: > Hello Maxime, > > > On Tue, Feb 2, 2016 at 9:17 PM, Maxime Ripard > wrote: > > Hi, > > > > On Sun, Jan 31, 2016 at 09:20:56AM +0800, Vishnu Patekar wrote: > >> AHB1 on A83T is similar to ahb1 on A31, except parents are different. > >> clock index 0b1x is PLL6. > >> > >> Signed-off-by: Vishnu Patekar > > > > If the clock is the same but the parents are different, then we don't > > need to duplicate all the logic. Simply add the number of parents to > > mux_data, and you're all set. > > Problem here is: parent 0b10 for A31 ahb1 is AXI, 0b11 is pll6/pre_div. > 0b10 and 0b11 is pll6/pre_div. > So, just adding number of parents to mux_data will not solve problem. Is anyone using 0b11 ? Can't we just ignore it? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ikeVEW9yuYc//A+q--