From: Tejun Heo <tj@kernel.org>
To: suman Tripathi <stripathi@apm.com>
Cc: devicetree@vger.kernel.org, mlangsdo@redhat.com, arnd@arndb.de,
jcm@redhat.com, patches@apm.com, linux-ide@vger.kernel.org,
olof@lixom.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] libahci: Implement the capability to override the generic ahci interrupt handler.
Date: Fri, 5 Feb 2016 11:41:22 -0500 [thread overview]
Message-ID: <20160205164122.GB4401@htj.duckdns.org> (raw)
In-Reply-To: <1454620826-22554-2-git-send-email-stripathi@apm.com>
Hello,
On Fri, Feb 05, 2016 at 02:50:24AM +0530, suman Tripathi wrote:
...
> @@ -2504,15 +2505,28 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
> struct ahci_host_priv *hpriv = host->private_data;
> int irq = hpriv->irq;
> int rc;
> + irqreturn_t (*ahci_irq_handler)(int irq, void *dev_instance);
>
> + ahci_irq_handler = hpriv->ahci_irq_intr;
> +
> + if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX)) {
> + if (!ahci_irq_handler)
> + rc = ahci_host_activate_multi_irqs(host, sht);
> + else
> + dev_warn(host->dev, "both AHCI_HFLAG_MULTI_MSI flag set \
> + and custom irq handler implemented\n");
> +
> + } else {
> + if (!ahci_irq_handler) {
> + ahci_irq_handler = (hpriv->flags & AHCI_HFLAG_EDGE_IRQ ?
> + ahci_single_edge_irq_intr :
> + ahci_single_level_irq_intr);
> + }
> + }
I wrote this before but can't we do this in save_initial_config the
same way ->start_engine override is handled?
--
tejun
next prev parent reply other threads:[~2016-02-05 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 21:20 [PATCH v3 0/3] ata: Fixes related to edge trigger latch for the ahci_xgene_driver suman Tripathi
2016-02-04 21:20 ` [PATCH v3 1/3] libahci: Implement the capability to override the generic ahci interrupt handler suman Tripathi
2016-02-05 14:12 ` Sergei Shtylyov
2016-02-05 16:41 ` Tejun Heo [this message]
2016-02-05 18:06 ` Suman Tripathi
[not found] ` <1454620826-22554-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2016-02-04 21:20 ` [PATCH v3 2/3] libahci: ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci suman Tripathi
2016-02-04 21:20 ` [PATCH v3 3/3] ahci_xgene: Implement the workaround to fix the missing of edge interrupt for HOST_IRQ_STAT suman Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205164122.GB4401@htj.duckdns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).