* [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes
@ 2016-01-16 14:13 Dirk Behme
2016-02-03 17:20 ` Dirk Behme
0 siblings, 1 reply; 5+ messages in thread
From: Dirk Behme @ 2016-01-16 14:13 UTC (permalink / raw)
To: linux-sh, horms, geert+renesas
Cc: devicetree, linux-arm-kernel, sudeep.holla, Dirk Behme
Instead of using the generic armv8-pmuv3 compatibility use the more
specific Cortex A57 compatibility.
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
---
Changes in v2: Drop the not yet merged Cortex A53 part.
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 266c5de..a82bce8 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -247,8 +247,8 @@
power-domains = <&cpg>;
};
- pmu {
- compatible = "arm,armv8-pmuv3";
+ pmu_a57 {
+ compatible = "arm,cortex-a57-pmu";
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes
2016-01-16 14:13 [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes Dirk Behme
@ 2016-02-03 17:20 ` Dirk Behme
2016-02-05 9:54 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Dirk Behme @ 2016-02-03 17:20 UTC (permalink / raw)
To: linux-sh, horms, geert+renesas; +Cc: devicetree, linux-arm-kernel, sudeep.holla
On 16.01.2016 15:13, Dirk Behme wrote:
> Instead of using the generic armv8-pmuv3 compatibility use the more
> specific Cortex A57 compatibility.
>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> ---
> Changes in v2: Drop the not yet merged Cortex A53 part.
>
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 266c5de..a82bce8 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -247,8 +247,8 @@
> power-domains = <&cpg>;
> };
>
> - pmu {
> - compatible = "arm,armv8-pmuv3";
> + pmu_a57 {
> + compatible = "arm,cortex-a57-pmu";
> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
>
Any further comments to this? If not, could this be applied?
Best regards
Dirk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes
2016-02-03 17:20 ` Dirk Behme
@ 2016-02-05 9:54 ` Simon Horman
2016-02-05 10:03 ` Dirk Behme
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2016-02-05 9:54 UTC (permalink / raw)
To: Dirk Behme
Cc: linux-sh, geert+renesas, devicetree, linux-arm-kernel,
sudeep.holla, linux-renesas-soc
[CC shiny new linux-renesas-soc ML]
On Wed, Feb 03, 2016 at 06:20:52PM +0100, Dirk Behme wrote:
> On 16.01.2016 15:13, Dirk Behme wrote:
> >Instead of using the generic armv8-pmuv3 compatibility use the more
> >specific Cortex A57 compatibility.
> >
> >Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> >---
> >Changes in v2: Drop the not yet merged Cortex A53 part.
> >
> > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >index 266c5de..a82bce8 100644
> >--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >@@ -247,8 +247,8 @@
> > power-domains = <&cpg>;
> > };
> >
> >- pmu {
> >- compatible = "arm,armv8-pmuv3";
> >+ pmu_a57 {
> >+ compatible = "arm,cortex-a57-pmu";
> > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> >
>
>
> Any further comments to this? If not, could this be applied?
Hi Dirk,
I apologise for loosing track of this one.
Does this change work? I saw some discussion about using arm,cortex-a57-pmu
not working correctly on the r8a7795 in an earlier thread.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes
2016-02-05 9:54 ` Simon Horman
@ 2016-02-05 10:03 ` Dirk Behme
2016-02-08 9:21 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Dirk Behme @ 2016-02-05 10:03 UTC (permalink / raw)
To: Simon Horman, Dirk Behme
Cc: linux-sh, geert+renesas, devicetree, linux-arm-kernel,
sudeep.holla, linux-renesas-soc
On 05.02.2016 10:54, Simon Horman wrote:
> [CC shiny new linux-renesas-soc ML]
Yes, thanks. I've to learn and remember this, too :)
> On Wed, Feb 03, 2016 at 06:20:52PM +0100, Dirk Behme wrote:
>> On 16.01.2016 15:13, Dirk Behme wrote:
>>> Instead of using the generic armv8-pmuv3 compatibility use the more
>>> specific Cortex A57 compatibility.
>>>
>>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>> ---
>>> Changes in v2: Drop the not yet merged Cortex A53 part.
>>>
>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index 266c5de..a82bce8 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -247,8 +247,8 @@
>>> power-domains = <&cpg>;
>>> };
>>>
>>> - pmu {
>>> - compatible = "arm,armv8-pmuv3";
>>> + pmu_a57 {
>>> + compatible = "arm,cortex-a57-pmu";
>>> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
>>> <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
>>> <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
>>>
>>
>>
>> Any further comments to this? If not, could this be applied?
>
> Hi Dirk,
>
> I apologise for loosing track of this one.
>
> Does this change work? I saw some discussion about using arm,cortex-a57-pmu
> not working correctly on the r8a7795 in an earlier thread.
Yes, the A57 PMU probe is successful.
What's not working with the latest Renesas BSP is the A53, because these
cores are disabled in the firmware coming with that BSP. But that's not
a PMU issue, it's just because the cores are disabled. Using an older
BSP firmware enabling all cores makes the A53 PMU probe fine, too.
Best regards
Dirk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes
2016-02-05 10:03 ` Dirk Behme
@ 2016-02-08 9:21 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2016-02-08 9:21 UTC (permalink / raw)
To: Dirk Behme
Cc: Dirk Behme, linux-sh, geert+renesas, devicetree, linux-arm-kernel,
sudeep.holla, linux-renesas-soc
On Fri, Feb 05, 2016 at 11:03:36AM +0100, Dirk Behme wrote:
> On 05.02.2016 10:54, Simon Horman wrote:
> >[CC shiny new linux-renesas-soc ML]
>
>
> Yes, thanks. I've to learn and remember this, too :)
>
>
> >On Wed, Feb 03, 2016 at 06:20:52PM +0100, Dirk Behme wrote:
> >>On 16.01.2016 15:13, Dirk Behme wrote:
> >>>Instead of using the generic armv8-pmuv3 compatibility use the more
> >>>specific Cortex A57 compatibility.
> >>>
> >>>Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> >>>---
> >>>Changes in v2: Drop the not yet merged Cortex A53 part.
> >>>
> >>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>>diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>index 266c5de..a82bce8 100644
> >>>--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >>>@@ -247,8 +247,8 @@
> >>> power-domains = <&cpg>;
> >>> };
> >>>
> >>>- pmu {
> >>>- compatible = "arm,armv8-pmuv3";
> >>>+ pmu_a57 {
> >>>+ compatible = "arm,cortex-a57-pmu";
> >>> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> >>> <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
> >>> <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> >>>
> >>
> >>
> >>Any further comments to this? If not, could this be applied?
> >
> >Hi Dirk,
> >
> >I apologise for loosing track of this one.
> >
> >Does this change work? I saw some discussion about using arm,cortex-a57-pmu
> >not working correctly on the r8a7795 in an earlier thread.
>
> Yes, the A57 PMU probe is successful.
>
> What's not working with the latest Renesas BSP is the A53, because these
> cores are disabled in the firmware coming with that BSP. But that's not a
> PMU issue, it's just because the cores are disabled. Using an older BSP
> firmware enabling all cores makes the A53 PMU probe fine, too.
Thanks for the explanation. I have queued up this patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-08 9:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-16 14:13 [PATCH v2] arm64: dts: r8a7795: pmu: switch to Cortex specific device nodes Dirk Behme
2016-02-03 17:20 ` Dirk Behme
2016-02-05 9:54 ` Simon Horman
2016-02-05 10:03 ` Dirk Behme
2016-02-08 9:21 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).