devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	tsahee@annapurnalabs.com, linux-arm-kernel@lists.infradead.org,
	rshitrit@annapurnalabs.com, thomas.petazzoni@free-electrons.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Barak Wasserstrom <barak@annapurnalabs.com>
Subject: Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP
Date: Mon, 8 Feb 2016 10:51:05 +0000	[thread overview]
Message-ID: <20160208105104.GA12991@leverpostej> (raw)
In-Reply-To: <1454922699-16785-3-git-send-email-antoine.tenart@free-electrons.com>

Hi,

> +	chosen {
> +		stdout-path = "console0:115200n8";
> +	};

There is no console0 alias, so this cannot work.

Did you mean serial0?

[...]

> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +		serial3 = &uart3;
> +	};

[...]

> +	psci {
> +		compatible = "arm,psci-0.2", "arm,psci";
> +		method = "smc";
> +		cpu_on = <0x84000003>;
> +	};

If you have PSCI 0.2, the cpu_on ID (and all other mandatory function
IDs) are implicit.

If you want to have "arm,psci" as a fallback, then please add the IDs
for functions mandatory in PSCI 0.2 which existed in the "arm,psci"
binding. Otherwise, drop "arm,psci" from the compatible list, along
with the cpu_on function ID.

THanks,
Mark.

  reply	other threads:[~2016-02-08 10:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1454922699-16785-1-git-send-email-antoine.tenart@free-electrons.com>
2016-02-08  9:11 ` [PATCH 2/3] arm64: dts: add the Alpine v2 EVP Antoine Tenart
2016-02-08 10:51   ` Mark Rutland [this message]
2016-02-08 11:00     ` Antoine Tenart
     [not found]   ` <1454922699-16785-3-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-02-08 12:20     ` Arnd Bergmann
2016-02-09 10:18       ` Antoine Tenart
2016-02-08 15:29   ` Marc Zyngier
2016-02-09  8:56     ` Antoine Tenart
2016-02-09  9:01       ` Antoine Tenart
2016-02-09  9:09         ` Marc Zyngier
     [not found]           ` <CABM=7knaepbyy4nw_GczVM7E_t6py7gG0ERs8ru_AYoVXvAQ+A@mail.gmail.com>
     [not found]             ` <CABM=7knaepbyy4nw_GczVM7E_t6py7gG0ERs8ru_AYoVXvAQ+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-09  9:30               ` Marc Zyngier
     [not found]                 ` <56B9B1B5.5070106-5wv7dgnIgG8@public.gmane.org>
2016-02-09 10:13                   ` Tsahee Zidenberg
     [not found]                     ` <CABM=7k=-Y+eFB2nUMfMjd3saTSNDsEyfHyYNf-ef8qQc5jCsxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-09 10:42                       ` Marc Zyngier
2016-02-09 11:48                       ` Marc Zyngier
     [not found]                         ` <56B9D20A.8010709-5wv7dgnIgG8@public.gmane.org>
2016-02-09 13:54                           ` Tsahee Zidenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208105104.GA12991@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=barak@annapurnalabs.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rshitrit@annapurnalabs.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tsahee@annapurnalabs.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).