From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sean Nyekjaer
<sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Daniel Baluta
<daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 4/4] iio: ad5755: Add full DT binding documentation
Date: Mon, 8 Feb 2016 11:37:27 -0600 [thread overview]
Message-ID: <20160208173727.GA823@rob-hp-laptop> (raw)
In-Reply-To: <56B63BAC.2040001-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Sat, Feb 06, 2016 at 06:30:04PM +0000, Jonathan Cameron wrote:
> On 03/02/16 14:31, Sean Nyekjaer wrote:
> > Signed-off-by: Sean Nyekjaer <sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
> Hmm. Complex beast. Going to want Lars to look at this in particular.
> Also a device tree review would be good on this one.
>
> My personal gut feeling is not to wrap up things that are really numeric
> with names, but rather to provide docs on the valid values for them.
> Not sure what is the preferred by the device tree guys??
Agreed. I'm not such a fan of defines in DT.
Also, if there is some possibility that bindings could be generic, I
prefer to see them use the native units rather than the enumerated
register values. The downside is adding the translation into the driver.
These look like they could possibly be generic DAC properties.
Rob
next prev parent reply other threads:[~2016-02-08 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 14:31 [PATCH v2 1/4] iio: ad5755: add support for dt bindings Sean Nyekjaer
[not found] ` <1454509864-32285-1-git-send-email-sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
2016-02-03 14:31 ` [PATCH v2 2/4] iio: ad5755: Add DT binding documentation Sean Nyekjaer
[not found] ` <1454509864-32285-2-git-send-email-sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
2016-02-03 14:31 ` [PATCH v2 3/4] iio: ad5755: added full support for devicetree Sean Nyekjaer
[not found] ` <1454509864-32285-3-git-send-email-sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
2016-02-03 14:31 ` [PATCH v2 4/4] iio: ad5755: Add full DT binding documentation Sean Nyekjaer
[not found] ` <1454509864-32285-4-git-send-email-sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
2016-02-06 18:30 ` Jonathan Cameron
[not found] ` <56B63BAC.2040001-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-02-08 17:37 ` Rob Herring [this message]
2016-02-09 8:22 ` [PATCH v2 3/4] iio: ad5755: added full support for devicetree Sean Nyekjær
[not found] ` <56B9A1B2.6030007-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org>
2016-02-09 20:30 ` Lars-Peter Clausen
[not found] ` <56BA4C74.9030503-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-02-16 13:46 ` Sean Nyekjær
2016-02-06 18:36 ` [PATCH v2 2/4] iio: ad5755: Add DT binding documentation Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208173727.GA823@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).