From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
catalin.marinas@arm.com, will.deacon@arm.com,
tsahee@annapurnalabs.com, linux-arm-kernel@lists.infradead.org,
rshitrit@annapurnalabs.com, thomas.petazzoni@free-electrons.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Barak Wasserstrom <barak@annapurnalabs.com>
Subject: Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP
Date: Tue, 9 Feb 2016 09:56:33 +0100 [thread overview]
Message-ID: <20160209085633.GA5388@kwain> (raw)
In-Reply-To: <56B8B45D.1020902@arm.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi Marc,
On Mon, Feb 08, 2016 at 03:29:33PM +0000, Marc Zyngier wrote:
> On 08/02/16 09:11, Antoine Tenart wrote:
>
> > + gic: gic@f0100000 {
> > + compatible = "arm,gic-v3";
> > + reg = <0x0 0xf0200000 0x0 0x10000>, /* GIC Dist */
> > + <0x0 0xf0280000 0x0 0x200000>, /* GICR */
> > + <0x0 0xf0100000 0x0 0x2000>; /* GICC */
> > + interrupt-controller;
> > + #interrupt-cells = <3>;
> > + };
>
> Something is wrong here. Either you are missing GICH and GICV (assuming
> you have legacy support), or you have an extra GICC region (which
> doesn't make sense on its own).
>
> You're also missing the maintenance interrupt.
>
> Has Anapurna really built a GICv3 without an ITS?
I documented myself and Annapurna's GIC really doesn't have an ITS.
I'll add the missing regions.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-09 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1454922699-16785-1-git-send-email-antoine.tenart@free-electrons.com>
2016-02-08 9:11 ` [PATCH 2/3] arm64: dts: add the Alpine v2 EVP Antoine Tenart
2016-02-08 10:51 ` Mark Rutland
2016-02-08 11:00 ` Antoine Tenart
[not found] ` <1454922699-16785-3-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-02-08 12:20 ` Arnd Bergmann
2016-02-09 10:18 ` Antoine Tenart
2016-02-08 15:29 ` Marc Zyngier
2016-02-09 8:56 ` Antoine Tenart [this message]
2016-02-09 9:01 ` Antoine Tenart
2016-02-09 9:09 ` Marc Zyngier
[not found] ` <CABM=7knaepbyy4nw_GczVM7E_t6py7gG0ERs8ru_AYoVXvAQ+A@mail.gmail.com>
[not found] ` <CABM=7knaepbyy4nw_GczVM7E_t6py7gG0ERs8ru_AYoVXvAQ+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-09 9:30 ` Marc Zyngier
[not found] ` <56B9B1B5.5070106-5wv7dgnIgG8@public.gmane.org>
2016-02-09 10:13 ` Tsahee Zidenberg
[not found] ` <CABM=7k=-Y+eFB2nUMfMjd3saTSNDsEyfHyYNf-ef8qQc5jCsxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-09 10:42 ` Marc Zyngier
2016-02-09 11:48 ` Marc Zyngier
[not found] ` <56B9D20A.8010709-5wv7dgnIgG8@public.gmane.org>
2016-02-09 13:54 ` Tsahee Zidenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209085633.GA5388@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=barak@annapurnalabs.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rshitrit@annapurnalabs.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tsahee@annapurnalabs.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).