From: David Miller <davem@davemloft.net>
To: isubramanian@apm.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, patches@apm.com,
toanle@apm.com, kdinh@apm.com, tinamdar@apm.com
Subject: Re: [PATCH net-next v2 1/4] drivers: net: xgene: Add support for Classifier engine
Date: Wed, 17 Feb 2016 12:05:17 -0500 (EST) [thread overview]
Message-ID: <20160217.120517.1874370262056055172.davem@davemloft.net> (raw)
In-Reply-To: <1455327425-8294-2-git-send-email-isubramanian@apm.com>
From: Iyappan Subramanian <isubramanian@apm.com>
Date: Fri, 12 Feb 2016 17:37:02 -0800
> +static void xgene_cle_dn_to_hw(struct xgene_cle_ptree_ewdn *dn,
> + u32 *buf, u32 jb)
> +{
> + u32 i, j = 0;
> + u32 npp;
> + struct xgene_cle_ptree_branch *br;
Please order local variables from longest to shortest line (reverse christmas
tree format).
Please address this for your entire submission.
Thank you.
next prev parent reply other threads:[~2016-02-17 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 1:37 [PATCH net-next v2 0/4] Add support for Classifier and RSS Iyappan Subramanian
2016-02-13 1:37 ` [PATCH net-next v2 1/4] drivers: net: xgene: Add support for Classifier engine Iyappan Subramanian
2016-02-17 17:05 ` David Miller [this message]
2016-02-13 1:37 ` [PATCH net-next v2 2/4] drivers: net: xgene: Add support for RSS Iyappan Subramanian
2016-02-13 1:37 ` [PATCH net-next v2 3/4] drivers: net: xgene: Add support for multiple queues Iyappan Subramanian
2016-02-13 1:37 ` [PATCH net-next v2 4/4] dtb: xgene: Add irqs to support multi queue Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217.120517.1874370262056055172.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=isubramanian@apm.com \
--cc=kdinh@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=patches@apm.com \
--cc=tinamdar@apm.com \
--cc=toanle@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).