[PATCH v2 1/2] Documentation: DT: Add entry for Freescale LS1043a-QDS board

[PATCH v2 1/2] Documentation: DT: Add entry for Freescale LS1043a-QDS board

[Zhiqiang Hou]

From: Hou Zhiqiang <Zhiqiang.Hou@freescale.com>

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@freescale.com>
---
new patch

 Documentation/devicetree/bindings/arm/fsl.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
index 752a685..dbbc095 100644
--- a/Documentation/devicetree/bindings/arm/fsl.txt
+++ b/Documentation/devicetree/bindings/arm/fsl.txt
@@ -135,6 +135,10 @@ LS1043A ARMv8 based RDB Board
 Required root node properties:
     - compatible = "fsl,ls1043a-rdb", "fsl,ls1043a";
 
+LS1043A ARMv8 based QDS Board
+Required root node properties:
+    - compatible = "fsl,ls1043a-qds", "fsl,ls1043a";
+
 LS2080A ARMv8 based Simulator model
 Required root node properties:
     - compatible = "fsl,ls2080a-simu", "fsl,ls2080a";
-- 
2.1.0.27.g96db324

[PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Zhiqiang Hou]

From: Shaohui Xie <Shaohui.Xie-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Signed-off-by: Shaohui Xie <Shaohui.Xie-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Mingkai Hu <Mingkai.Hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
v2:
 - add root node compatible property

 arch/arm64/boot/dts/freescale/Makefile            |   1 +
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 168 ++++++++++++++++++++++
 2 files changed, 169 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index f3c2516..1423fa4 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
  
 always		:= $(dtb-y)
 subdir-y	:= $(dts-dirs)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
new file mode 100644
index 0000000..d7aae69
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -0,0 +1,168 @@
+/*
+ * Device Tree Include file for Freescale Layerscape-1043A family SoC.
+ *
+ * Copyright 2014-2015, Freescale Semiconductor
+ *
+ * Mingkai Hu <Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This library is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This library is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+/include/ "fsl-ls1043a.dtsi"
+
+/ {
+	model = "LS1043A QDS Board";
+	compatible = "fsl,ls1043a-qds", "fsl,ls1043a";
+
+	aliases {
+		serial0 = &lpuart0;
+		serial1 = &lpuart1;
+		serial2 = &lpuart2;
+		serial3 = &lpuart3;
+		serial4 = &lpuart4;
+		serial5 = &lpuart5;
+
+		gpio0 = &gpio1;
+		gpio1 = &gpio2;
+		gpio2 = &gpio3;
+		gpio3 = &gpio4;
+	};
+};
+
+&i2c0 {
+	status = "okay";
+	pca9547@77 {
+		compatible = "philips,pca9547";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0>;
+
+			rtc@68 {
+				compatible = "dallas,ds3232";
+				reg = <0x68>;
+				/* IRQ10_B */
+				interrupts = <0 150 0x4>;
+			};
+		};
+
+		i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x2>;
+
+			ina220@40 {
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <1000>;
+			};
+
+			ina220@41 {
+				compatible = "ti,ina220";
+				reg = <0x41>;
+				shunt-resistor = <1000>;
+			};
+		};
+
+		i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			eeprom@56 {
+				compatible = "at24,24c512";
+				reg = <0x56>;
+			};
+
+			eeprom@57 {
+				compatible = "at24,24c512";
+				reg = <0x57>;
+			};
+
+			adt7461a@4c {
+				compatible = "adt7461a";
+				reg = <0x4c>;
+			};
+		};
+	};
+};
+
+&ifc {
+	status = "okay";
+	#address-cells = <2>;
+	#size-cells = <1>;
+	/* NOR, NAND Flashes and FPGA on board */
+	ranges = <0x0 0x0 0x0 0x60000000 0x08000000
+		  0x1 0x0 0x0 0x7e800000 0x00010000
+		  0x2 0x0 0x0 0x7fb00000 0x00000100>;
+
+	nor@0,0 {
+		compatible = "cfi-flash";
+		reg = <0x0 0x0 0x8000000>;
+		bank-width = <2>;
+		device-width = <1>;
+	};
+
+	nand@1,0 {
+		compatible = "fsl,ifc-nand";
+		reg = <0x1 0x0 0x10000>;
+	};
+
+	fpga: board-control@2,0 {
+		compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
+		reg = <0x2 0x0 0x0000100>;
+	};
+};
+
+&lpuart0 {
+	status = "okay";
+};
+
+&duart0 {
+	status = "okay";
+};
+
+&duart1 {
+	status = "okay";
+};
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Hou Zhiqiang]

Hi,

Any comments?

> From: Zhiqiang Hou <Zhiqiang.Hou@freescale.com>
> Sent: Thursday, December 24, 2015 5:11 PM
> To: devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com; pawel.moll@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org; linux-arm-kernel@lists.infradead.org; catalin.marinas@arm.com; will.deacon@arm.com
> Cc: Wood Scott-B07421; Hu Mingkai-B21284; Xie Shaohui-B21989; Hou Zhiqiang
> Subject: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
> 
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@freescale.com>
> --- 
> v2: 
>  - add root node compatible property
> 
>  arch/arm64/boot/dts/freescale/Makefile            |   1 + 
>  arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 168 ++++++++++++++++++++++
>  2 files changed, 169 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index f3c2516..1423fa4 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
> 
>  always         := $(dtb-y)
>  subdir-y       := $(dts-dirs)
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> new file mode 100644
> index 0000000..d7aae69
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -0,0 +1,168 @@
> +/* 
> + * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> + * 
> + * Copyright 2014-2015, Freescale Semiconductor
> + * 
> + * Mingkai Hu <Mingkai.hu@freescale.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This library is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +/include/ "fsl-ls1043a.dtsi"
> +
> +/ {
> +       model = "LS1043A QDS Board";
> +       compatible = "fsl,ls1043a-qds", "fsl,ls1043a";
> +
> +       aliases {
> +               serial0 = &lpuart0;
> +               serial1 = &lpuart1;
> +               serial2 = &lpuart2;
> +               serial3 = &lpuart3;
> +               serial4 = &lpuart4;
> +               serial5 = &lpuart5;
> +
> +               gpio0 = &gpio1;
> +               gpio1 = &gpio2;
> +               gpio2 = &gpio3;
> +               gpio3 = &gpio4;
> +       };
> +};
> +
> +&i2c0 {
> +       status = "okay";
> +       pca9547@77 {
> +               compatible = "philips,pca9547";
> +               reg = <0x77>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               i2c@0 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0x0>;
> +
> +                       rtc@68 {
> +                               compatible = "dallas,ds3232";
> +                               reg = <0x68>;
> +                               /* IRQ10_B */
> +                               interrupts = <0 150 0x4>;
> +                       };
> +               };
> +
> +               i2c@2 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0x2>;
> +
> +                       ina220@40 {
> +                               compatible = "ti,ina220";
> +                               reg = <0x40>;
> +                               shunt-resistor = <1000>;
> +                       };
> +
> +                       ina220@41 {
> +                               compatible = "ti,ina220";
> +                               reg = <0x41>;
> +                               shunt-resistor = <1000>;
> +                       };
> +               };
> +
> +               i2c@3 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <0x3>;
> +
> +                       eeprom@56 {
> +                               compatible = "at24,24c512";
> +                               reg = <0x56>;
> +                       };
> +
> +                       eeprom@57 {
> +                               compatible = "at24,24c512";
> +                               reg = <0x57>;
> +                       };
> +
> +                       adt7461a@4c {
> +                               compatible = "adt7461a";
> +                               reg = <0x4c>;
> +                       };
> +               };
> +       };
> +};
> +
> +&ifc {
> +       status = "okay";
> +       #address-cells = <2>;
> +       #size-cells = <1>;
> +       /* NOR, NAND Flashes and FPGA on board */
> +       ranges = <0x0 0x0 0x0 0x60000000 0x08000000
> +                 0x1 0x0 0x0 0x7e800000 0x00010000
> +                 0x2 0x0 0x0 0x7fb00000 0x00000100>;
> +
> +       nor@0,0 {
> +               compatible = "cfi-flash";
> +               reg = <0x0 0x0 0x8000000>;
> +               bank-width = <2>;
> +               device-width = <1>;
> +       };
> +
> +       nand@1,0 {
> +               compatible = "fsl,ifc-nand";
> +               reg = <0x1 0x0 0x10000>;
> +       };
> +
> +       fpga: board-control@2,0 {
> +               compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
> +               reg = <0x2 0x0 0x0000100>;
> +       };
> +};
> +
> +&lpuart0 {
> +       status = "okay";
> +};
> +
> +&duart0 {
> +       status = "okay";
> +};
> +
> +&duart1 {
> +       status = "okay";
> +};
> --
> 2.1.0.27.g96db324

Thanks,
Zhiqiang

Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Shawn Guo]

On Thu, Dec 24, 2015 at 05:11:38PM +0800, Zhiqiang Hou wrote:
> From: Shaohui Xie <Shaohui.Xie-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 

Empty commit log is generally not welcomed.  You can have something here
to introduce the board briefly.

We generally use lowercase for arm64 patch subject prefix, i.e.
"arm64: dts: ...".  Yes, this is different from ARM.

> Signed-off-by: Shaohui Xie <Shaohui.Xie-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Signed-off-by: Mingkai Hu <Mingkai.Hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> v2:
>  - add root node compatible property
> 
>  arch/arm64/boot/dts/freescale/Makefile            |   1 +
>  arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 168 ++++++++++++++++++++++
>  2 files changed, 169 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index f3c2516..1423fa4 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb

The list should be sorted alphabetically.  But it's not your fault, as
fsl-ls1043a-rdb.dtb is already wrong.

>   
>  always		:= $(dtb-y)
>  subdir-y	:= $(dts-dirs)
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> new file mode 100644
> index 0000000..d7aae69
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -0,0 +1,168 @@
> +/*
> + * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> + *
> + * Copyright 2014-2015, Freescale Semiconductor
> + *
> + * Mingkai Hu <Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This library is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +/include/ "fsl-ls1043a.dtsi"
> +
> +/ {
> +	model = "LS1043A QDS Board";
> +	compatible = "fsl,ls1043a-qds", "fsl,ls1043a";
> +
> +	aliases {
> +		serial0 = &lpuart0;
> +		serial1 = &lpuart1;
> +		serial2 = &lpuart2;
> +		serial3 = &lpuart3;
> +		serial4 = &lpuart4;
> +		serial5 = &lpuart5;
> +

This new line is not really necessary.

> +		gpio0 = &gpio1;
> +		gpio1 = &gpio2;
> +		gpio2 = &gpio3;
> +		gpio3 = &gpio4;

I suggest to sort all these aliases entries alphabetically.

> +	};
> +};
> +
> +&i2c0 {
> +	status = "okay";

I suggest to have a new line between properties and sub-node.

> +	pca9547@77 {
> +		compatible = "philips,pca9547";

I cannot find this compatible string in either binding docs or driver
code.

> +		reg = <0x77>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		i2c@0 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x0>;
> +
> +			rtc@68 {
> +				compatible = "dallas,ds3232";
> +				reg = <0x68>;
> +				/* IRQ10_B */
> +				interrupts = <0 150 0x4>;
> +			};
> +		};
> +
> +		i2c@2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x2>;
> +
> +			ina220@40 {
> +				compatible = "ti,ina220";
> +				reg = <0x40>;
> +				shunt-resistor = <1000>;
> +			};
> +
> +			ina220@41 {
> +				compatible = "ti,ina220";
> +				reg = <0x41>;
> +				shunt-resistor = <1000>;
> +			};
> +		};
> +
> +		i2c@3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x3>;
> +
> +			eeprom@56 {
> +				compatible = "at24,24c512";

Unsupported/undocumented compatible?

> +				reg = <0x56>;
> +			};
> +
> +			eeprom@57 {
> +				compatible = "at24,24c512";
> +				reg = <0x57>;
> +			};
> +
> +			adt7461a@4c {

temp-sensor should be a better node name, if I understand the device
correctly.

> +				compatible = "adt7461a";

It should be "adi,adt7461a" per
Documentation/devicetree/bindings/hwmon/lm90.txt?

> +				reg = <0x4c>;
> +			};
> +		};
> +	};
> +};
> +
> +&ifc {
> +	status = "okay";

We generally put it at the bottom of the property list.

> +	#address-cells = <2>;
> +	#size-cells = <1>;
> +	/* NOR, NAND Flashes and FPGA on board */
> +	ranges = <0x0 0x0 0x0 0x60000000 0x08000000
> +		  0x1 0x0 0x0 0x7e800000 0x00010000
> +		  0x2 0x0 0x0 0x7fb00000 0x00000100>;
> +
> +	nor@0,0 {
> +		compatible = "cfi-flash";
> +		reg = <0x0 0x0 0x8000000>;
> +		bank-width = <2>;
> +		device-width = <1>;
> +	};
> +
> +	nand@1,0 {
> +		compatible = "fsl,ifc-nand";
> +		reg = <0x1 0x0 0x10000>;
> +	};
> +
> +	fpga: board-control@2,0 {
> +		compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
> +		reg = <0x2 0x0 0x0000100>;
> +	};
> +};
> +
> +&lpuart0 {
> +	status = "okay";
> +};
> +
> +&duart0 {
> +	status = "okay";
> +};
> +
> +&duart1 {
> +	status = "okay";
> +};

I suggest you sort these node alphabetically per label name.

Shawn

> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Zhiqiang Hou]

Hi Shawn,

Thanks for your comments!

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: 2016年2月19日 11:29
> To: Zhiqiang Hou <Zhiqiang.Hou@freescale.com>
> Cc: devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> pawel.moll@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org;
> linux-arm-kernel@lists.infradead.org; catalin.marinas@arm.com;
> will.deacon@arm.com; scottwood@freescale.com; Mingkai.Hu@freescale.com;
> Shaohui.Xie@freescale.com
> Subject: Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
> 
> On Thu, Dec 24, 2015 at 05:11:38PM +0800, Zhiqiang Hou wrote:
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> >
> 
> Empty commit log is generally not welcomed.  You can have something here to
> introduce the board briefly.
> 

Will add the introduce in v3. 

> We generally use lowercase for arm64 patch subject prefix, i.e.
> "arm64: dts: ...".  Yes, this is different from ARM.
 
Yes, will fix in v3.

> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@freescale.com>
> > ---
> > v2:
> >  - add root node compatible property
> >
> >  arch/arm64/boot/dts/freescale/Makefile            |   1 +
> >  arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 168
> > ++++++++++++++++++++++
> >  2 files changed, 169 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index f3c2516..1423fa4 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
> > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
> 
> The list should be sorted alphabetically.  But it's not your fault, as fsl-ls1043a-
> rdb.dtb is already wrong.
> 
> >
> >  always		:= $(dtb-y)
> >  subdir-y	:= $(dts-dirs)
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > new file mode 100644
> > index 0000000..d7aae69
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > @@ -0,0 +1,168 @@
> > +/*
> > + * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> > + *
> > + * Copyright 2014-2015, Freescale Semiconductor
> > + *
> > + * Mingkai Hu <Mingkai.hu@freescale.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPLv2 or the X11 license, at your option. Note that this
> > +dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This library is free software; you can redistribute it and/or
> > + *     modify it under the terms of the GNU General Public License as
> > + *     published by the Free Software Foundation; either version 2 of the
> > + *     License, or (at your option) any later version.
> > + *
> > + *     This library is distributed in the hope that it will be useful,
> > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *     GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + *     obtaining a copy of this software and associated documentation
> > + *     files (the "Software"), to deal in the Software without
> > + *     restriction, including without limitation the rights to use,
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or
> > + *     sell copies of the Software, and to permit persons to whom the
> > + *     Software is furnished to do so, subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and this permission notice shall be
> > + *     included in all copies or substantial portions of the Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +/include/ "fsl-ls1043a.dtsi"
> > +
> > +/ {
> > +	model = "LS1043A QDS Board";
> > +	compatible = "fsl,ls1043a-qds", "fsl,ls1043a";
> > +
> > +	aliases {
> > +		serial0 = &lpuart0;
> > +		serial1 = &lpuart1;
> > +		serial2 = &lpuart2;
> > +		serial3 = &lpuart3;
> > +		serial4 = &lpuart4;
> > +		serial5 = &lpuart5;
> > +
> 
> This new line is not really necessary.
> 
> > +		gpio0 = &gpio1;
> > +		gpio1 = &gpio2;
> > +		gpio2 = &gpio3;
> > +		gpio3 = &gpio4;
> 
> I suggest to sort all these aliases entries alphabetically.
> 

Yes, this will be arranged in v3.

> > +	};
> > +};
> > +
> > +&i2c0 {
> > +	status = "okay";
> 
> I suggest to have a new line between properties and sub-node.
> 

Yes, will add a new line here.
 
> > +	pca9547@77 {
> > +		compatible = "philips,pca9547";
> 
> I cannot find this compatible string in either binding docs or driver code.
> 

See the file below.
./drivers/i2c/muxes/i2c-mux-pca954x.c:115:	{ "pca9547", pca_9547 },
Perhaps the vender name should be updated to nxp.

> > +		reg = <0x77>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		i2c@0 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0>;
> > +
> > +			rtc@68 {
> > +				compatible = "dallas,ds3232";
> > +				reg = <0x68>;
> > +				/* IRQ10_B */
> > +				interrupts = <0 150 0x4>;
> > +			};
> > +		};
> > +
> > +		i2c@2 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x2>;
> > +
> > +			ina220@40 {
> > +				compatible = "ti,ina220";
> > +				reg = <0x40>;
> > +				shunt-resistor = <1000>;
> > +			};
> > +
> > +			ina220@41 {
> > +				compatible = "ti,ina220";
> > +				reg = <0x41>;
> > +				shunt-resistor = <1000>;
> > +			};
> > +		};
> > +
> > +		i2c@3 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x3>;
> > +
> > +			eeprom@56 {
> > +				compatible = "at24,24c512";
> 
> Unsupported/undocumented compatible?

Will change it to "atmel, 24c512".

> 
> > +				reg = <0x56>;
> > +			};
> > +
> > +			eeprom@57 {
> > +				compatible = "at24,24c512";
> > +				reg = <0x57>;
> > +			};
> > +
> > +			adt7461a@4c {
> 
> temp-sensor should be a better node name, if I understand the device correctly.
> 

I didn't find a reference in kernel, so what name should be better, do you have any advice?

> > +				compatible = "adt7461a";
> 
> It should be "adi,adt7461a" per
> Documentation/devicetree/bindings/hwmon/lm90.txt?
> 

Yes, will fix it in v3.

> > +				reg = <0x4c>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&ifc {
> > +	status = "okay";
> 
> We generally put it at the bottom of the property list.
> 

Will fix it in v3.

> > +	#address-cells = <2>;
> > +	#size-cells = <1>;
> > +	/* NOR, NAND Flashes and FPGA on board */
> > +	ranges = <0x0 0x0 0x0 0x60000000 0x08000000
> > +		  0x1 0x0 0x0 0x7e800000 0x00010000
> > +		  0x2 0x0 0x0 0x7fb00000 0x00000100>;
> > +
> > +	nor@0,0 {
> > +		compatible = "cfi-flash";
> > +		reg = <0x0 0x0 0x8000000>;
> > +		bank-width = <2>;
> > +		device-width = <1>;
> > +	};
> > +
> > +	nand@1,0 {
> > +		compatible = "fsl,ifc-nand";
> > +		reg = <0x1 0x0 0x10000>;
> > +	};
> > +
> > +	fpga: board-control@2,0 {
> > +		compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
> > +		reg = <0x2 0x0 0x0000100>;
> > +	};
> > +};
> > +
> > +&lpuart0 {
> > +	status = "okay";
> > +};
> > +
> > +&duart0 {
> > +	status = "okay";
> > +};
> > +
> > +&duart1 {
> > +	status = "okay";
> > +};
> 
> I suggest you sort these node alphabetically per label name.
> 

Yes, will resort these nodes in v3.

Thanks,
Zhiqiang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Shawn Guo]

On Fri, Feb 19, 2016 at 10:10:04AM +0000, Zhiqiang Hou wrote:

<snip>

> > > +	pca9547@77 {
> > > +		compatible = "philips,pca9547";
> > 
> > I cannot find this compatible string in either binding docs or driver code.
> > 
> 
> See the file below.
> ./drivers/i2c/muxes/i2c-mux-pca954x.c:115:	{ "pca9547", pca_9547 },
> Perhaps the vender name should be updated to nxp.

Yes, if you look at Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
"nxp,pca9547" is the one you should use here.

<snip>

> > > +			eeprom@56 {
> > > +				compatible = "at24,24c512";
> > 
> > Unsupported/undocumented compatible?
> 
> Will change it to "atmel, 24c512".

Yes, but without the space in the middle.

> 
> > 
> > > +				reg = <0x56>;
> > > +			};
> > > +
> > > +			eeprom@57 {
> > > +				compatible = "at24,24c512";
> > > +				reg = <0x57>;
> > > +			};
> > > +
> > > +			adt7461a@4c {
> > 
> > temp-sensor should be a better node name, if I understand the device correctly.
> > 
> 
> I didn't find a reference in kernel, so what name should be better, do you have any advice?

"temp-sensor" is what I see from the example in
Documentation/devicetree/bindings/hwmon/lm90.txt.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Zhiqiang Hou]

Hi Shawn,

Thanks for your advice!

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: 2016年2月28日 10:38
> To: Zhiqiang Hou <zhiqiang.hou@nxp.com>
> Cc: Zhiqiang Hou <Zhiqiang.Hou@freescale.com>; mark.rutland@arm.com;
> devicetree@vger.kernel.org; Shaohui.Xie@freescale.com; pawel.moll@arm.com;
> ijc+devicetree@hellion.org.uk; catalin.marinas@arm.com; will.deacon@arm.com;
> robh+dt@kernel.org; galak@codeaurora.org; scottwood@freescale.com;
> Mingkai.Hu@freescale.com; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
> 
> On Fri, Feb 19, 2016 at 10:10:04AM +0000, Zhiqiang Hou wrote:
> 
> <snip>
> 
> > > > +	pca9547@77 {
> > > > +		compatible = "philips,pca9547";
> > >
> > > I cannot find this compatible string in either binding docs or driver code.
> > >
> >
> > See the file below.
> > ./drivers/i2c/muxes/i2c-mux-pca954x.c:115:	{ "pca9547", pca_9547 },
> > Perhaps the vender name should be updated to nxp.
> 
> Yes, if you look at Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
> "nxp,pca9547" is the one you should use here.
> 
> <snip>
> 
> > > > +			eeprom@56 {
> > > > +				compatible = "at24,24c512";
> > >
> > > Unsupported/undocumented compatible?
> >
> > Will change it to "atmel, 24c512".
> 
> Yes, but without the space in the middle.
> 
> >
> > >
> > > > +				reg = <0x56>;
> > > > +			};
> > > > +
> > > > +			eeprom@57 {
> > > > +				compatible = "at24,24c512";
> > > > +				reg = <0x57>;
> > > > +			};
> > > > +
> > > > +			adt7461a@4c {
> > >
> > > temp-sensor should be a better node name, if I understand the device correctly.
> > >
> >
> > I didn't find a reference in kernel, so what name should be better, do you have
> any advice?
> 
> "temp-sensor" is what I see from the example in
> Documentation/devicetree/bindings/hwmon/lm90.txt.
> 

Thanks,
Zhiqiang

Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Li Yang]

Hi Zhiqiang,

Will there be a v3 coming out before the 4.6 merge windows?

Regards,
Leo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support

[Zhiqiang Hou]

Hi Leo,

Yes, I am busy with ls1046a emu and sdk working those days, and will submit v3 before next Tuesday.

Thanks,
Zhiqiang

> -----Original Message-----
> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] On Behalf Of Li Yang
> Sent: 2016年3月4日 4:28
> To: Zhiqiang Hou <zhiqiang.hou@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Zhiqiang Hou
> <Zhiqiang.Hou@freescale.com>; mark.rutland@arm.com;
> devicetree@vger.kernel.org; Shaohui.Xie@freescale.com; pawel.moll@arm.com;
> ijc+devicetree@hellion.org.uk; catalin.marinas@arm.com; will.deacon@arm.com;
> robh+dt@kernel.org; galak@codeaurora.org; scottwood@freescale.com;
> Mingkai.Hu@freescale.com; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
> 
> Hi Zhiqiang,
> 
> Will there be a v3 coming out before the 4.6 merge windows?
> 
> Regards,
> Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] Documentation: DT: Add entry for Freescale LS1043a-QDS board

[Rob Herring]

On Thu, Dec 24, 2015 at 05:11:37PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> new patch
> 
>  Documentation/devicetree/bindings/arm/fsl.txt | 4 ++++
>  1 file changed, 4 insertions(+)

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html