* [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants
@ 2016-02-21 11:06 Pali Rohár
2016-02-21 16:28 ` Sebastian Reichel
[not found] ` <1456052808-14461-1-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: Pali Rohár @ 2016-02-21 11:06 UTC (permalink / raw)
To: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Pavel Machel,
Aaro Koskinen, Sebastian Reichel, Ivaylo Dimitrov, Nishanth Menon
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Pali Rohár
This makes DTS structure more readable.
Signed-off-by: Pali Rohár <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/omap3-n900.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index e0443cd..85c29f3 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -65,45 +65,45 @@
camera_lens_cover {
label = "Camera Lens Cover";
gpios = <&gpio4 14 GPIO_ACTIVE_LOW>; /* 110 */
- linux,input-type = <5>; /* EV_SW */
- linux,code = <0x09>; /* SW_CAMERA_LENS_COVER */
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_CAMERA_LENS_COVER>;
wakeup-source;
};
camera_focus {
label = "Camera Focus";
gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; /* 68 */
- linux,code = <0x210>; /* KEY_CAMERA_FOCUS */
+ linux,code = <KEY_CAMERA_FOCUS>;
wakeup-source;
};
camera_capture {
label = "Camera Capture";
gpios = <&gpio3 5 GPIO_ACTIVE_LOW>; /* 69 */
- linux,code = <0xd4>; /* KEY_CAMERA */
+ linux,code = <KEY_CAMERA>;
wakeup-source;
};
lock_button {
label = "Lock Button";
gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; /* 113 */
- linux,code = <0x98>; /* KEY_SCREENLOCK */
+ linux,code = <KEY_SCREENLOCK>;
wakeup-source;
};
keypad_slide {
label = "Keypad Slide";
gpios = <&gpio3 7 GPIO_ACTIVE_LOW>; /* 71 */
- linux,input-type = <5>; /* EV_SW */
- linux,code = <0x0a>; /* SW_KEYPAD_SLIDE */
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_KEYPAD_SLIDE>;
wakeup-source;
};
proximity_sensor {
label = "Proximity Sensor";
gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; /* 89 */
- linux,input-type = <5>; /* EV_SW */
- linux,code = <0x0b>; /* SW_FRONT_PROXIMITY */
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_FRONT_PROXIMITY>;
};
};
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants
2016-02-21 11:06 [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants Pali Rohár
@ 2016-02-21 16:28 ` Sebastian Reichel
[not found] ` <1456052808-14461-1-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2016-02-21 16:28 UTC (permalink / raw)
To: Pali Rohár
Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Pavel Machel,
Aaro Koskinen, Ivaylo Dimitrov, Nishanth Menon, linux-omap,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2208 bytes --]
Hi,
On Sun, Feb 21, 2016 at 12:06:48PM +0100, Pali Rohár wrote:
> This makes DTS structure more readable.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index e0443cd..85c29f3 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -65,45 +65,45 @@
> camera_lens_cover {
> label = "Camera Lens Cover";
> gpios = <&gpio4 14 GPIO_ACTIVE_LOW>; /* 110 */
> - linux,input-type = <5>; /* EV_SW */
> - linux,code = <0x09>; /* SW_CAMERA_LENS_COVER */
> + linux,input-type = <EV_SW>;
> + linux,code = <SW_CAMERA_LENS_COVER>;
> wakeup-source;
> };
>
> camera_focus {
> label = "Camera Focus";
> gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; /* 68 */
> - linux,code = <0x210>; /* KEY_CAMERA_FOCUS */
> + linux,code = <KEY_CAMERA_FOCUS>;
> wakeup-source;
> };
>
> camera_capture {
> label = "Camera Capture";
> gpios = <&gpio3 5 GPIO_ACTIVE_LOW>; /* 69 */
> - linux,code = <0xd4>; /* KEY_CAMERA */
> + linux,code = <KEY_CAMERA>;
> wakeup-source;
> };
>
> lock_button {
> label = "Lock Button";
> gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; /* 113 */
> - linux,code = <0x98>; /* KEY_SCREENLOCK */
> + linux,code = <KEY_SCREENLOCK>;
> wakeup-source;
> };
>
> keypad_slide {
> label = "Keypad Slide";
> gpios = <&gpio3 7 GPIO_ACTIVE_LOW>; /* 71 */
> - linux,input-type = <5>; /* EV_SW */
> - linux,code = <0x0a>; /* SW_KEYPAD_SLIDE */
> + linux,input-type = <EV_SW>;
> + linux,code = <SW_KEYPAD_SLIDE>;
> wakeup-source;
> };
>
> proximity_sensor {
> label = "Proximity Sensor";
> gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; /* 89 */
> - linux,input-type = <5>; /* EV_SW */
> - linux,code = <0x0b>; /* SW_FRONT_PROXIMITY */
> + linux,input-type = <EV_SW>;
> + linux,code = <SW_FRONT_PROXIMITY>;
> };
> };
>
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <1456052808-14461-1-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants
[not found] ` <1456052808-14461-1-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-02-22 10:55 ` Pavel Machek
2016-02-22 19:02 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2016-02-22 10:55 UTC (permalink / raw)
To: Pali Rohár
Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Aaro Koskinen,
Sebastian Reichel, Ivaylo Dimitrov, Nishanth Menon,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sun 2016-02-21 12:06:48, Pali Rohár wrote:
> This makes DTS structure more readable.
>
> Signed-off-by: Pali Rohár <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants
2016-02-22 10:55 ` Pavel Machek
@ 2016-02-22 19:02 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2016-02-22 19:02 UTC (permalink / raw)
To: Pavel Machek
Cc: Pali Rohár, Benoît Cousson, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Aaro Koskinen,
Sebastian Reichel, Ivaylo Dimitrov, Nishanth Menon,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
* Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> [160222 02:55]:
> On Sun 2016-02-21 12:06:48, Pali Rohár wrote:
> > This makes DTS structure more readable.
> >
> > Signed-off-by: Pali Rohár <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Acked-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Applying into omap-for-v4.6/dt.
Thanks,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-22 19:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-21 11:06 [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants Pali Rohár
2016-02-21 16:28 ` Sebastian Reichel
[not found] ` <1456052808-14461-1-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-22 10:55 ` Pavel Machek
2016-02-22 19:02 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).