From: Mark Rutland <mark.rutland@arm.com>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: andy.gross@linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock
Date: Tue, 23 Feb 2016 17:39:45 +0000 [thread overview]
Message-ID: <20160223173944.GA10088@leverpostej> (raw)
In-Reply-To: <1456248071-30547-1-git-send-email-georgi.djakov@linaro.org>
On Tue, Feb 23, 2016 at 07:21:11PM +0200, Georgi Djakov wrote:
> When the SMEM is probed it defers as it depends on the hardware lock, which
> is not available yet. But the SMD bus and RPM regulators and clocks depend
> on SMEM and they defer too. The problem with this is that the order of
> registering the devices is not optimal and also we may end with messed
> up serial console as the RPM clocks are not registered yet..
Re-ordering the DT is fragile at best, and not a real solution to this
class of problem.
Why can the drivers not defer probing in this case?
Mark.
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 7705207872a5..c497c7b1ae70 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -113,15 +113,6 @@
> };
> };
>
> - smem {
> - compatible = "qcom,smem";
> -
> - memory-region = <&smem_mem>;
> - qcom,rpm-msg-ram = <&rpm_msg_ram>;
> -
> - hwlocks = <&tcsr_mutex 3>;
> - };
> -
> soc: soc {
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -512,6 +503,16 @@
> };
> };
>
> + smem {
> + compatible = "qcom,smem";
> +
> + memory-region = <&smem_mem>;
> + qcom,rpm-msg-ram = <&rpm_msg_ram>;
> +
> + hwlocks = <&tcsr_mutex 3>;
> + };
> +
> +
> smd {
> compatible = "qcom,smd";
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-23 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 17:21 [PATCH] arm64: dts: msm8916: Move smem below hwlock Georgi Djakov
2016-02-23 17:29 ` Srinivas Kandagatla
2016-02-23 18:47 ` Georgi Djakov
[not found] ` <56CCA95C.9070207-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-23 19:03 ` Andy Gross
2016-02-24 10:31 ` Georgi Djakov
2016-02-23 19:28 ` Srinivas Kandagatla
2016-02-23 20:18 ` Georgi Djakov
2016-02-23 17:39 ` Mark Rutland [this message]
2016-02-24 6:00 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223173944.GA10088@leverpostej \
--to=mark.rutland@arm.com \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).