From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Zhao Qiang <qiang.zhao-3arQi8VN3Tc@public.gmane.org>
Cc: oss-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org,
leoyang.li-3arQi8VN3Tc@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
Date: Tue, 23 Feb 2016 14:23:42 -0600 [thread overview]
Message-ID: <20160223202342.GA9008@rob-hp-laptop> (raw)
In-Reply-To: <1455757572-44955-3-git-send-email-qiang.zhao-3arQi8VN3Tc@public.gmane.org>
On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao-3arQi8VN3Tc@public.gmane.org>
> ---
> Changes for v2
> - modify tx/rx-clock-name specification
>
> .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> new file mode 100644
> index 0000000..436c71c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> @@ -0,0 +1,19 @@
> +* Serial
> +
> +Currently defined compatibles:
> +- ucc_uart
> +
> +Properties for ucc_uart:
> +port-number : port number of UCC-UART
How is this used?
> +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> + should be "clk1"-"clk28" for external clock source.
Perhaps you should be using the clock binding here and in other
bindings?
> +
> +Example:
> +
> + ucc_serial: ucc@2200 {
> + device_type = "serial";
> + compatible = "ucc_uart";
> + port-number = <1>;
> + rx-clock-name = "brg2";
> + tx-clock-name = "brg2";
> + };
> --
> 2.1.0.27.g96db324
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-23 20:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-02-23 20:21 ` Rob Herring
2016-02-25 4:37 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
[not found] ` <1455757572-44955-3-git-send-email-qiang.zhao-3arQi8VN3Tc@public.gmane.org>
2016-02-23 20:23 ` Rob Herring [this message]
2016-02-23 20:27 ` Scott Wood
2016-02-25 4:44 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
[not found] ` <1455757572-44955-4-git-send-email-qiang.zhao-3arQi8VN3Tc@public.gmane.org>
2016-02-23 20:24 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
2016-02-23 20:20 ` Scott Wood
2016-02-25 3:10 ` Qiang Zhao
2016-02-25 3:11 ` Scott Wood
2016-02-25 5:55 ` Qiang Zhao
2016-02-25 5:56 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223202342.GA9008@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=leoyang.li-3arQi8VN3Tc@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=oss-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org \
--cc=qiang.zhao-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox