* [PATCH] ARM: dts: spear: replace gpio-key,wakeup with wakeup-source property
@ 2016-02-08 21:55 Sudeep Holla
[not found] ` <1454968535-11994-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2016-02-08 21:55 UTC (permalink / raw)
To: Viresh Kumar, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: spear-devel-nkJGhpqTU55BDgjK7y7TUQ,
devicetree-u79uwXL29TY76Z2rM5mHXA, Sudeep Holla
Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
"gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
source.
Few dts files assign value "1" to gpio-key,wakeup which is incorrect.
Since the presence of the boolean property indicates it is enabled,
value of "0" or "1" have no significance.
This patch replaces the legacy "gpio-key,wakeup" with the unified
"wakeup-source" property which inturn fixes the above mentioned issue.
Reviewed-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
---
arch/arm/boot/dts/spear1310-evb.dts | 2 +-
arch/arm/boot/dts/spear1340-evb.dts | 2 +-
arch/arm/boot/dts/spear320-hmi.dts | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
Hi ARM-SoC guys,
This is the only platform which doesn't have regular pull request,
Viresh has acked it already. Can you pick this up directly for v4.6 ?
Regards,
Sudeep
diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts
index e48857249ce7..84101e4eebbf 100644
--- a/arch/arm/boot/dts/spear1310-evb.dts
+++ b/arch/arm/boot/dts/spear1310-evb.dts
@@ -161,7 +161,7 @@
linux,code = <0x100>;
gpios = <&gpio0 7 0x4>;
debounce-interval = <20>;
- gpio-key,wakeup = <1>;
+ wakeup-source;
};
};
diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts
index c611f5606dfe..6565f3cb866f 100644
--- a/arch/arm/boot/dts/spear1340-evb.dts
+++ b/arch/arm/boot/dts/spear1340-evb.dts
@@ -223,7 +223,7 @@
linux,code = <0x100>;
gpios = <&gpio1 1 0x4>;
debounce-interval = <20>;
- gpio-key,wakeup = <1>;
+ wakeup-source;
};
};
diff --git a/arch/arm/boot/dts/spear320-hmi.dts b/arch/arm/boot/dts/spear320-hmi.dts
index 0aa6fef5ce22..0d0da1f65f0e 100644
--- a/arch/arm/boot/dts/spear320-hmi.dts
+++ b/arch/arm/boot/dts/spear320-hmi.dts
@@ -141,7 +141,7 @@
linux,code = <0x100>;
gpios = <&stmpegpio 3 0x4>;
debounce-interval = <20>;
- gpio-key,wakeup = <1>;
+ wakeup-source;
};
button@2 {
@@ -149,7 +149,7 @@
linux,code = <0x200>;
gpios = <&stmpegpio 2 0x4>;
debounce-interval = <20>;
- gpio-key,wakeup = <1>;
+ wakeup-source;
};
};
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1454968535-11994-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>]
* [PATCH] ARM: dts: spear: replace gpio-key,wakeup with wakeup-source property [not found] ` <1454968535-11994-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org> @ 2016-02-09 15:44 ` Sudeep Holla [not found] ` <1455032699-3086-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Sudeep Holla @ 2016-02-09 15:44 UTC (permalink / raw) To: arm-DgEjT+Ai2ygdnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: Viresh Kumar, Arnd Bergmann, Olof Johansson, devicetree-u79uwXL29TY76Z2rM5mHXA, Sudeep Holla Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source. Few dts files assign value "1" to gpio-key,wakeup which is incorrect. Since the presence of the boolean property indicates it is enabled, value of "0" or "1" have no significance. This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property which inturn fixes the above mentioned issue. Reviewed-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> --- arch/arm/boot/dts/spear1310-evb.dts | 2 +- arch/arm/boot/dts/spear1340-evb.dts | 2 +- arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) (this time adding arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org correctly) Hi ARM-SoC guys, This is the only platform which doesn't have regular pull request, Viresh has acked it already. Can you pick this up directly for v4.6 ? Regards, Sudeep diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts index e48857249ce7..84101e4eebbf 100644 --- a/arch/arm/boot/dts/spear1310-evb.dts +++ b/arch/arm/boot/dts/spear1310-evb.dts @@ -161,7 +161,7 @@ linux,code = <0x100>; gpios = <&gpio0 7 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; }; diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts index c611f5606dfe..6565f3cb866f 100644 --- a/arch/arm/boot/dts/spear1340-evb.dts +++ b/arch/arm/boot/dts/spear1340-evb.dts @@ -223,7 +223,7 @@ linux,code = <0x100>; gpios = <&gpio1 1 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; }; diff --git a/arch/arm/boot/dts/spear320-hmi.dts b/arch/arm/boot/dts/spear320-hmi.dts index 0aa6fef5ce22..0d0da1f65f0e 100644 --- a/arch/arm/boot/dts/spear320-hmi.dts +++ b/arch/arm/boot/dts/spear320-hmi.dts @@ -141,7 +141,7 @@ linux,code = <0x100>; gpios = <&stmpegpio 3 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; button@2 { @@ -149,7 +149,7 @@ linux,code = <0x200>; gpios = <&stmpegpio 2 0x4>; debounce-interval = <20>; - gpio-key,wakeup = <1>; + wakeup-source; }; }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1455032699-3086-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] ARM: dts: spear: replace gpio-key,wakeup with wakeup-source property [not found] ` <1455032699-3086-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org> @ 2016-02-24 20:20 ` Olof Johansson 0 siblings, 0 replies; 3+ messages in thread From: Olof Johansson @ 2016-02-24 20:20 UTC (permalink / raw) To: Sudeep Holla Cc: arm-DgEjT+Ai2ygdnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Viresh Kumar, Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA On Tue, Feb 09, 2016 at 03:44:59PM +0000, Sudeep Holla wrote: > Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy > "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup > source. > > Few dts files assign value "1" to gpio-key,wakeup which is incorrect. > Since the presence of the boolean property indicates it is enabled, > value of "0" or "1" have no significance. > > This patch replaces the legacy "gpio-key,wakeup" with the unified > "wakeup-source" property which inturn fixes the above mentioned issue. > > Reviewed-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> > --- > arch/arm/boot/dts/spear1310-evb.dts | 2 +- > arch/arm/boot/dts/spear1340-evb.dts | 2 +- > arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > (this time adding arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org correctly) > > Hi ARM-SoC guys, > > This is the only platform which doesn't have regular pull request, > Viresh has acked it already. Can you pick this up directly for v4.6 ? Thanks, applied. -Olof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-24 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 21:55 [PATCH] ARM: dts: spear: replace gpio-key,wakeup with wakeup-source property Sudeep Holla
[not found] ` <1454968535-11994-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2016-02-09 15:44 ` Sudeep Holla
[not found] ` <1455032699-3086-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2016-02-24 20:20 ` Olof Johansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).