devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Lars Persson <lars.persson-VrBV9hrLPhE@public.gmane.org>,
	arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Lars Persson <larper-VrBV9hrLPhE@public.gmane.org>
Subject: Re: [PATCH v3 0/6] arm: Add Artpec-6 SoC
Date: Wed, 24 Feb 2016 14:00:03 -0800	[thread overview]
Message-ID: <20160224220003.GO10126@localhost> (raw)
In-Reply-To: <2697188.EpDoHh0fx4@wuerfel>

Hej,

On Thu, Feb 11, 2016 at 05:20:27PM +0100, Arnd Bergmann wrote:
> On Thursday 11 February 2016 17:06:15 Lars Persson wrote:
> > Basic support for the Axis Artpec-6 ARM SoC. Timers, interrupts, UARTs and
> > ethernet are wired up.
> > 
> > Changes since v2:
> > - Create a syscon binding for the system controller.
> > - Clock patches split out to new patch series "clk: Add Artpec-6 SoC support".
> 
> Looks all good to me now, impressive for v3 on a new platform port!
> 
> We'll apply it in the next few days, unless further review comments come in.

Indeed, nice and clean. I have two minor nits:

1) We prefix with ARM:, not arm:. I fixed this up for you. I also added ARM:
   dts: artpeg: ... on the dts changes. Not a huge deail on those.

2) Several of the patches lacked description. Subject pretty much says it all,
   but it's still nice to have a sentence or two as description. Again, not
   a huge deal, and I applied anyway, but for the future think about it.


That being said, I've applied the series across next/soc, next/dt and
next/defconfig. Thanks!


-Olof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2016-02-24 22:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 16:06 [PATCH v3 0/6] arm: Add Artpec-6 SoC Lars Persson
2016-02-11 16:06 ` [PATCH v3 1/6] arm: add device-tree SoC bindings for Axis Artpec-6 Lars Persson
     [not found]   ` <0a38251ad8ad1895a1744f43a58f6b161676af09.1455205057.git.larper-VrBV9hrLPhE@public.gmane.org>
2016-02-12 16:40     ` Rob Herring
2016-02-11 16:06 ` [PATCH v3 2/6] arm: dts: add Artpec-6 SoC dtsi file Lars Persson
2016-02-25  0:29   ` Olof Johansson
2016-02-11 16:06 ` [PATCH v3 3/6] arm: dts: add Artpec-6 development board dts Lars Persson
2016-02-11 16:06 ` [PATCH v3 4/6] arm: initial machine port for artpec-6 SoC Lars Persson
2016-02-11 16:06 ` [PATCH v3 5/6] arm: multi_v7_defconfig: add MACH_ARTPEC6 Lars Persson
2016-02-11 16:06 ` [PATCH v3 6/6] arm: mach-artpec: add entry to MAINTAINERS Lars Persson
2016-02-11 16:20 ` [PATCH v3 0/6] arm: Add Artpec-6 SoC Arnd Bergmann
2016-02-24 22:00   ` Olof Johansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160224220003.GO10126@localhost \
    --to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
    --cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=larper-VrBV9hrLPhE@public.gmane.org \
    --cc=lars.persson-VrBV9hrLPhE@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).