From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] Add triggers for cubietruck leds Date: Thu, 25 Feb 2016 10:41:39 -0800 Message-ID: <20160225184139.GG4736@lukather> References: <1456304247-2481-1-git-send-email-henry@nitronetworks.nl> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vSsTm1kUtxIHoa7M" Return-path: Content-Disposition: inline In-Reply-To: <1456304247-2481-1-git-send-email-henry-oxlTVf6CAJF4HdFT58BDcQ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Henry Paulissen Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --vSsTm1kUtxIHoa7M Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Wed, Feb 24, 2016 at 09:57:25AM +0100, Henry Paulissen wrote: > This (small) patch gives the same led trigger functionality > as the 3.4 sunxi kernel and although mainline doesn't has > to be the same, it helps in identifying and builds upon the > user expectations about what those leds mean. > > Signed-off-by: Henry Paulissen We don't take these trigger patches because it should be left for the user to decide, and everyone has a different opinion on that. It's something that you can also very easily enforce from the userspace through sysfs. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --vSsTm1kUtxIHoa7M--