* [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes @ 2016-03-01 3:57 Masahiro Yamada 2016-03-01 11:46 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Mark Rutland 2016-03-03 20:44 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Rob Herring 0 siblings, 2 replies; 7+ messages in thread From: Masahiro Yamada @ 2016-03-01 3:57 UTC (permalink / raw) To: arm-DgEjT+Ai2ygdnm+yROfE0A Cc: David Brown, devicetree-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Russell King, Heiko Stuebner, Pawel Moll, Ian Campbell, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, Mark Rutland, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Masahiro Yamada, Kukjin Kim, Wei Xu, Kumar Gala, Andy Gross, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Dinh Nguyen, linux-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r The "arm,amba-bus" string in the of_default_bus_match_table is ambiguous. This prepares for killing it off in a long run. Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> --- arch/arm/boot/dts/axm55xx.dtsi | 2 +- arch/arm/boot/dts/exynos3250.dtsi | 2 +- arch/arm/boot/dts/exynos4.dtsi | 2 +- arch/arm/boot/dts/exynos4415.dtsi | 2 +- arch/arm/boot/dts/exynos5250.dtsi | 2 +- arch/arm/boot/dts/exynos5420.dtsi | 2 +- arch/arm/boot/dts/exynos5440.dtsi | 2 +- arch/arm/boot/dts/hi3620.dtsi | 2 +- arch/arm/boot/dts/hip01.dtsi | 2 +- arch/arm/boot/dts/hisi-x5hd2.dtsi | 2 +- arch/arm/boot/dts/qcom-apq8064.dtsi | 2 +- arch/arm/boot/dts/qcom-msm8660.dtsi | 2 +- arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- arch/arm/boot/dts/rk3036.dtsi | 2 +- arch/arm/boot/dts/rk3228.dtsi | 2 +- arch/arm/boot/dts/rk3288.dtsi | 2 +- arch/arm/boot/dts/rk3xxx.dtsi | 2 +- arch/arm/boot/dts/s5pv210.dtsi | 2 +- arch/arm/boot/dts/socfpga.dtsi | 2 +- arch/arm/boot/dts/socfpga_arria10.dtsi | 2 +- arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 2 +- arch/arm/boot/dts/ste-u300.dts | 2 +- arch/arm/boot/dts/versatile-ab.dts | 2 +- 23 files changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi index ea288f0..8da4582 100644 --- a/arch/arm/boot/dts/axm55xx.dtsi +++ b/arch/arm/boot/dts/axm55xx.dtsi @@ -107,7 +107,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <2>; #size-cells = <2>; ranges; diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 18e3def..0ad4fa7 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -381,7 +381,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 045785c..d53fd78 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -661,7 +661,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; interrupt-parent = <&gic>; ranges; diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi index ad76484..35d2f99 100644 --- a/arch/arm/boot/dts/exynos4415.dtsi +++ b/arch/arm/boot/dts/exynos4415.dtsi @@ -380,7 +380,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; interrupt-parent = <&gic>; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 33e2d5f..bcaed08 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -674,7 +674,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; interrupt-parent = <&gic>; ranges; diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 48a0a55..838bde3 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -327,7 +327,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; interrupt-parent = <&gic>; ranges; diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi index f18b51f..5fe5639 100644 --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm/boot/dts/exynos5440.dtsi @@ -200,7 +200,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; interrupt-parent = <&gic>; ranges; }; diff --git a/arch/arm/boot/dts/hi3620.dtsi b/arch/arm/boot/dts/hi3620.dtsi index 6cbb62e..7b67ffe 100644 --- a/arch/arm/boot/dts/hi3620.dtsi +++ b/arch/arm/boot/dts/hi3620.dtsi @@ -68,7 +68,7 @@ #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; interrupt-parent = <&gic>; ranges = <0 0xfc000000 0x2000000>; diff --git a/arch/arm/boot/dts/hip01.dtsi b/arch/arm/boot/dts/hip01.dtsi index 33130f8..0835627 100644 --- a/arch/arm/boot/dts/hip01.dtsi +++ b/arch/arm/boot/dts/hip01.dtsi @@ -43,7 +43,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; ranges; uart0: uart@10001000 { diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index c52722b..f3a79b7 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -34,7 +34,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; ranges; timer0: timer@00002000 { diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi index ed521e8..ca93486 100644 --- a/arch/arm/boot/dts/qcom-apq8064.dtsi +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi @@ -721,7 +721,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi index e5f7f33..e05773c 100644 --- a/arch/arm/boot/dts/qcom-msm8660.dtsi +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi @@ -167,7 +167,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi index 51a40d8..7e7e891 100644 --- a/arch/arm/boot/dts/qcom-msm8960.dtsi +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi @@ -251,7 +251,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi index b9567c1..c15fdf4 100644 --- a/arch/arm/boot/dts/rk3036.dtsi +++ b/arch/arm/boot/dts/rk3036.dtsi @@ -94,7 +94,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/rk3228.dtsi b/arch/arm/boot/dts/rk3228.dtsi index 119ff12..8b4e443 100644 --- a/arch/arm/boot/dts/rk3228.dtsi +++ b/arch/arm/boot/dts/rk3228.dtsi @@ -96,7 +96,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 8ac49f3..af111fa 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -134,7 +134,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/rk3xxx.dtsi b/arch/arm/boot/dts/rk3xxx.dtsi index 99eeea7..c969e84 100644 --- a/arch/arm/boot/dts/rk3xxx.dtsi +++ b/arch/arm/boot/dts/rk3xxx.dtsi @@ -67,7 +67,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 8344a0e..e945c343 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -130,7 +130,7 @@ amba { #address-cells = <1>; #size-cells = <1>; - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; ranges; pdma0: dma@e0900000 { diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi index 3ed4abd..cadc637 100644 --- a/arch/arm/boot/dts/socfpga.dtsi +++ b/arch/arm/boot/dts/socfpga.dtsi @@ -69,7 +69,7 @@ ranges; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi index cce9e50..06a8e86 100644 --- a/arch/arm/boot/dts/socfpga_arria10.dtsi +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi @@ -63,7 +63,7 @@ ranges; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi index 27a333e..74732e4 100644 --- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi +++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi @@ -721,7 +721,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/ste-u300.dts b/arch/arm/boot/dts/ste-u300.dts index 9c73ac2..763a607 100644 --- a/arch/arm/boot/dts/ste-u300.dts +++ b/arch/arm/boot/dts/ste-u300.dts @@ -384,7 +384,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts index 6fd7efb..01156cf 100644 --- a/arch/arm/boot/dts/versatile-ab.dts +++ b/arch/arm/boot/dts/versatile-ab.dts @@ -148,7 +148,7 @@ }; amba { - compatible = "arm,amba-bus"; + compatible = "arm,amba-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" compatible nodes 2016-03-01 3:57 [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes Masahiro Yamada @ 2016-03-01 11:46 ` Mark Rutland 2016-03-03 3:07 ` Masahiro Yamada 2016-03-03 20:44 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Rob Herring 1 sibling, 1 reply; 7+ messages in thread From: Mark Rutland @ 2016-03-01 11:46 UTC (permalink / raw) To: Masahiro Yamada Cc: arm, Russell King, Kukjin Kim, Krzysztof Kozlowski, Heiko Stuebner, devicetree, linux-kernel, linux-arm-msm, Kumar Gala, Andy Gross, Dinh Nguyen, Ian Campbell, linux-samsung-soc, Rob Herring, David Brown, Pawel Moll, Wei Xu, linux-rockchip, linux-soc, linux-arm-kernel On Tue, Mar 01, 2016 at 12:57:00PM +0900, Masahiro Yamada wrote: > The "arm,amba-bus" string in the of_default_bus_match_table is > ambiguous. This prepares for killing it off in a long run. I don't follow the purpose of this patch. There's no way we can remove kernel-side support for "arm,amba-bus", as there are DTBs that rely on it. If we're going to merge "arm,amba-bus" in the kernel with "simple-bus", such that there is no distinction between the two, then that doesn't require any DTBs to be updated. The only reason I would see for changing dts files would be a subsequent clean-up for consistency, but at that point "arm,amba-bus" could be dropped entirely. So this patch makes no sense to me. Thanks, Mark. > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/arm/boot/dts/axm55xx.dtsi | 2 +- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos4.dtsi | 2 +- > arch/arm/boot/dts/exynos4415.dtsi | 2 +- > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > arch/arm/boot/dts/exynos5420.dtsi | 2 +- > arch/arm/boot/dts/exynos5440.dtsi | 2 +- > arch/arm/boot/dts/hi3620.dtsi | 2 +- > arch/arm/boot/dts/hip01.dtsi | 2 +- > arch/arm/boot/dts/hisi-x5hd2.dtsi | 2 +- > arch/arm/boot/dts/qcom-apq8064.dtsi | 2 +- > arch/arm/boot/dts/qcom-msm8660.dtsi | 2 +- > arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- > arch/arm/boot/dts/rk3036.dtsi | 2 +- > arch/arm/boot/dts/rk3228.dtsi | 2 +- > arch/arm/boot/dts/rk3288.dtsi | 2 +- > arch/arm/boot/dts/rk3xxx.dtsi | 2 +- > arch/arm/boot/dts/s5pv210.dtsi | 2 +- > arch/arm/boot/dts/socfpga.dtsi | 2 +- > arch/arm/boot/dts/socfpga_arria10.dtsi | 2 +- > arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 2 +- > arch/arm/boot/dts/ste-u300.dts | 2 +- > arch/arm/boot/dts/versatile-ab.dts | 2 +- > 23 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi > index ea288f0..8da4582 100644 > --- a/arch/arm/boot/dts/axm55xx.dtsi > +++ b/arch/arm/boot/dts/axm55xx.dtsi > @@ -107,7 +107,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <2>; > #size-cells = <2>; > ranges; > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 18e3def..0ad4fa7 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -381,7 +381,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 045785c..d53fd78 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -661,7 +661,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > interrupt-parent = <&gic>; > ranges; > > diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi > index ad76484..35d2f99 100644 > --- a/arch/arm/boot/dts/exynos4415.dtsi > +++ b/arch/arm/boot/dts/exynos4415.dtsi > @@ -380,7 +380,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > interrupt-parent = <&gic>; > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 33e2d5f..bcaed08 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -674,7 +674,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > interrupt-parent = <&gic>; > ranges; > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 48a0a55..838bde3 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -327,7 +327,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > interrupt-parent = <&gic>; > ranges; > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi > index f18b51f..5fe5639 100644 > --- a/arch/arm/boot/dts/exynos5440.dtsi > +++ b/arch/arm/boot/dts/exynos5440.dtsi > @@ -200,7 +200,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > interrupt-parent = <&gic>; > ranges; > }; > diff --git a/arch/arm/boot/dts/hi3620.dtsi b/arch/arm/boot/dts/hi3620.dtsi > index 6cbb62e..7b67ffe 100644 > --- a/arch/arm/boot/dts/hi3620.dtsi > +++ b/arch/arm/boot/dts/hi3620.dtsi > @@ -68,7 +68,7 @@ > > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > interrupt-parent = <&gic>; > ranges = <0 0xfc000000 0x2000000>; > > diff --git a/arch/arm/boot/dts/hip01.dtsi b/arch/arm/boot/dts/hip01.dtsi > index 33130f8..0835627 100644 > --- a/arch/arm/boot/dts/hip01.dtsi > +++ b/arch/arm/boot/dts/hip01.dtsi > @@ -43,7 +43,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > ranges; > > uart0: uart@10001000 { > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > index c52722b..f3a79b7 100644 > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > @@ -34,7 +34,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > ranges; > > timer0: timer@00002000 { > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index ed521e8..ca93486 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -721,7 +721,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi > index e5f7f33..e05773c 100644 > --- a/arch/arm/boot/dts/qcom-msm8660.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi > @@ -167,7 +167,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index 51a40d8..7e7e891 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -251,7 +251,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi > index b9567c1..c15fdf4 100644 > --- a/arch/arm/boot/dts/rk3036.dtsi > +++ b/arch/arm/boot/dts/rk3036.dtsi > @@ -94,7 +94,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/rk3228.dtsi b/arch/arm/boot/dts/rk3228.dtsi > index 119ff12..8b4e443 100644 > --- a/arch/arm/boot/dts/rk3228.dtsi > +++ b/arch/arm/boot/dts/rk3228.dtsi > @@ -96,7 +96,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 8ac49f3..af111fa 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -134,7 +134,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/rk3xxx.dtsi b/arch/arm/boot/dts/rk3xxx.dtsi > index 99eeea7..c969e84 100644 > --- a/arch/arm/boot/dts/rk3xxx.dtsi > +++ b/arch/arm/boot/dts/rk3xxx.dtsi > @@ -67,7 +67,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index 8344a0e..e945c343 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -130,7 +130,7 @@ > amba { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > ranges; > > pdma0: dma@e0900000 { > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index 3ed4abd..cadc637 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -69,7 +69,7 @@ > ranges; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi > index cce9e50..06a8e86 100644 > --- a/arch/arm/boot/dts/socfpga_arria10.dtsi > +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi > @@ -63,7 +63,7 @@ > ranges; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi > index 27a333e..74732e4 100644 > --- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi > +++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi > @@ -721,7 +721,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/ste-u300.dts b/arch/arm/boot/dts/ste-u300.dts > index 9c73ac2..763a607 100644 > --- a/arch/arm/boot/dts/ste-u300.dts > +++ b/arch/arm/boot/dts/ste-u300.dts > @@ -384,7 +384,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts > index 6fd7efb..01156cf 100644 > --- a/arch/arm/boot/dts/versatile-ab.dts > +++ b/arch/arm/boot/dts/versatile-ab.dts > @@ -148,7 +148,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" compatible nodes 2016-03-01 11:46 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Mark Rutland @ 2016-03-03 3:07 ` Masahiro Yamada 2016-03-03 10:12 ` [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" " Jon Medhurst (Tixy) 0 siblings, 1 reply; 7+ messages in thread From: Masahiro Yamada @ 2016-03-03 3:07 UTC (permalink / raw) To: Mark Rutland, Rob Herring Cc: arm, Russell King, Kukjin Kim, Krzysztof Kozlowski, Heiko Stuebner, devicetree, Linux Kernel Mailing List, linux-arm-msm, Kumar Gala, Andy Gross, Dinh Nguyen, Ian Campbell, linux-samsung-soc, David Brown, Pawel Moll, Wei Xu, open list:ARM/Rockchip SoC..., linux-soc, linux-arm-kernel Hi Mark, 2016-03-01 20:46 GMT+09:00 Mark Rutland <mark.rutland@arm.com>: > On Tue, Mar 01, 2016 at 12:57:00PM +0900, Masahiro Yamada wrote: >> The "arm,amba-bus" string in the of_default_bus_match_table is >> ambiguous. This prepares for killing it off in a long run. > > I don't follow the purpose of this patch. > > There's no way we can remove kernel-side support for "arm,amba-bus", as > there are DTBs that rely on it. > > If we're going to merge "arm,amba-bus" in the kernel with "simple-bus", > such that there is no distinction between the two, then that doesn't > require any DTBs to be updated. > > The only reason I would see for changing dts files would be a subsequent > clean-up for consistency, but at that point "arm,amba-bus" could be > dropped entirely. > > So this patch makes no sense to me. > > Thanks, > Mark. > This patch is derived from Rob Herring' comment "BTW, we should also kill off "amba-bus" which is an ambiguous term" in the following thread: http://lkml.iu.edu/hypermail/linux/kernel/1601.0/01822.html So, the plan would be like this: [1] Make device trees not depend on "arm,amba-bus" (this commit) [2] New device trees should no longer use "arm,amba-bus" alone. [3] Go though some releases until we do not care about the backward compatibility [4] Drop "arm,amba-bus" from of_default_bus_match_table No? -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes 2016-03-03 3:07 ` Masahiro Yamada @ 2016-03-03 10:12 ` Jon Medhurst (Tixy) [not found] ` <1456999975.2856.18.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Jon Medhurst (Tixy) @ 2016-03-03 10:12 UTC (permalink / raw) To: Masahiro Yamada Cc: Mark Rutland, Rob Herring, devicetree, Krzysztof Kozlowski, linux-samsung-soc, Russell King, Heiko Stuebner, Pawel Moll, Ian Campbell, linux-arm-msm, Linux Kernel Mailing List, Wei Xu, David Brown, arm, Kukjin Kim, Kumar Gala, Andy Gross, open list:ARM/Rockchip SoC..., Dinh Nguyen, linux-soc, linux-arm-kernel On Thu, 2016-03-03 at 12:07 +0900, Masahiro Yamada wrote: [...] > This patch is derived from Rob Herring' comment > "BTW, we should also kill off "amba-bus" which is an ambiguous term" > in the following thread: > http://lkml.iu.edu/hypermail/linux/kernel/1601.0/01822.html > > > So, the plan would be like this: > > [1] Make device trees not depend on "arm,amba-bus" (this commit) > [2] New device trees should no longer use "arm,amba-bus" alone. > [3] Go though some releases until we do not care about the backward > compatibility Why would we stop caring about backwards compatibility? If I was a user of any of the platforms in question and updated my kernel, I wouldn't expect to have to debug why it was broken, then install a new dtb to fix it - which may be a tricky thing to do, depending on the firmware used to boot Linux. > [4] Drop "arm,amba-bus" from of_default_bus_match_table -- Tixy ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1456999975.2856.18.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes [not found] ` <1456999975.2856.18.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> @ 2016-03-03 20:23 ` Rob Herring 2016-03-08 5:54 ` Masahiro Yamada 0 siblings, 1 reply; 7+ messages in thread From: Rob Herring @ 2016-03-03 20:23 UTC (permalink / raw) To: Jon Medhurst (Tixy) Cc: Masahiro Yamada, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Krzysztof Kozlowski, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King, Heiko Stuebner, Pawel Moll, Ian Campbell, linux-arm-msm, Linux Kernel Mailing List, Wei Xu, arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, David Brown, Kukjin Kim, Kumar Gala, Andy Gross, open list:ARM/Rockchip SoC..., Dinh Nguyen, linux-soc-u79uwXL29TY76Z2rM5mHXA On Thu, Mar 3, 2016 at 4:12 AM, Jon Medhurst (Tixy) <tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: > On Thu, 2016-03-03 at 12:07 +0900, Masahiro Yamada wrote: > [...] >> This patch is derived from Rob Herring' comment >> "BTW, we should also kill off "amba-bus" which is an ambiguous term" >> in the following thread: >> http://lkml.iu.edu/hypermail/linux/kernel/1601.0/01822.html >> >> >> So, the plan would be like this: >> >> [1] Make device trees not depend on "arm,amba-bus" (this commit) >> [2] New device trees should no longer use "arm,amba-bus" alone. >> [3] Go though some releases until we do not care about the backward >> compatibility > > Why would we stop caring about backwards compatibility? If I was a user > of any of the platforms in question and updated my kernel, I wouldn't > expect to have to debug why it was broken, then install a new dtb to fix > it - which may be a tricky thing to do, depending on the firmware used > to boot Linux. If no one notices, then there is no ABI. Things break all the time when nobody cares. It will be more than a few releases for sure. We may never get to step 3, but we should do step 1 so people stop copy-n-pasting this in step 2. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes 2016-03-03 20:23 ` Rob Herring @ 2016-03-08 5:54 ` Masahiro Yamada 0 siblings, 0 replies; 7+ messages in thread From: Masahiro Yamada @ 2016-03-08 5:54 UTC (permalink / raw) To: Rob Herring Cc: Jon Medhurst (Tixy), Mark Rutland, devicetree@vger.kernel.org, Krzysztof Kozlowski, linux-samsung-soc@vger.kernel.org, Russell King, Heiko Stuebner, Pawel Moll, Ian Campbell, linux-arm-msm, Linux Kernel Mailing List, Wei Xu, arm@kernel.org, David Brown, Kukjin Kim, Kumar Gala, Andy Gross, open list:ARM/Rockchip SoC..., Dinh Nguyen, linux-soc, linux-arm-k Hi Rob, Mark, Jon, Setting aside the future plan, anyway we should avoid relying on an undocumented compatible string. (and we should avoid its spread as Rob pointed out.) I rephrase the git-log (no update in the code-diff). Could you check v2, please? https://patchwork.kernel.org/patch/8529701/ Better? 2016-03-04 5:23 GMT+09:00 Rob Herring <robh+dt@kernel.org>: > On Thu, Mar 3, 2016 at 4:12 AM, Jon Medhurst (Tixy) <tixy@linaro.org> wrote: >> On Thu, 2016-03-03 at 12:07 +0900, Masahiro Yamada wrote: >> [...] >>> This patch is derived from Rob Herring' comment >>> "BTW, we should also kill off "amba-bus" which is an ambiguous term" >>> in the following thread: >>> http://lkml.iu.edu/hypermail/linux/kernel/1601.0/01822.html >>> >>> >>> So, the plan would be like this: >>> >>> [1] Make device trees not depend on "arm,amba-bus" (this commit) >>> [2] New device trees should no longer use "arm,amba-bus" alone. >>> [3] Go though some releases until we do not care about the backward >>> compatibility >> >> Why would we stop caring about backwards compatibility? If I was a user >> of any of the platforms in question and updated my kernel, I wouldn't >> expect to have to debug why it was broken, then install a new dtb to fix >> it - which may be a tricky thing to do, depending on the firmware used >> to boot Linux. > > If no one notices, then there is no ABI. Things break all the time > when nobody cares. It will be more than a few releases for sure. We > may never get to step 3, but we should do step 1 so people stop > copy-n-pasting this in step 2. > > Rob > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" compatible nodes 2016-03-01 3:57 [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes Masahiro Yamada 2016-03-01 11:46 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Mark Rutland @ 2016-03-03 20:44 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2016-03-03 20:44 UTC (permalink / raw) To: Masahiro Yamada Cc: arm@kernel.org, Russell King, Kukjin Kim, Krzysztof Kozlowski, Heiko Stuebner, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm, Kumar Gala, Andy Gross, Dinh Nguyen, Ian Campbell, linux-samsung-soc@vger.kernel.org, David Brown, Pawel Moll, Wei Xu, open list:ARM/Rockchip SoC..., Mark Rutland, linux-soc On Mon, Feb 29, 2016 at 9:57 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > The "arm,amba-bus" string in the of_default_bus_match_table is > ambiguous. This prepares for killing it off in a long run. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/arm/boot/dts/axm55xx.dtsi | 2 +- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos4.dtsi | 2 +- > arch/arm/boot/dts/exynos4415.dtsi | 2 +- > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > arch/arm/boot/dts/exynos5420.dtsi | 2 +- > arch/arm/boot/dts/exynos5440.dtsi | 2 +- > arch/arm/boot/dts/hi3620.dtsi | 2 +- > arch/arm/boot/dts/hip01.dtsi | 2 +- > arch/arm/boot/dts/hisi-x5hd2.dtsi | 2 +- > arch/arm/boot/dts/qcom-apq8064.dtsi | 2 +- > arch/arm/boot/dts/qcom-msm8660.dtsi | 2 +- > arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- > arch/arm/boot/dts/rk3036.dtsi | 2 +- > arch/arm/boot/dts/rk3228.dtsi | 2 +- > arch/arm/boot/dts/rk3288.dtsi | 2 +- > arch/arm/boot/dts/rk3xxx.dtsi | 2 +- > arch/arm/boot/dts/s5pv210.dtsi | 2 +- > arch/arm/boot/dts/socfpga.dtsi | 2 +- > arch/arm/boot/dts/socfpga_arria10.dtsi | 2 +- > arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 2 +- > arch/arm/boot/dts/ste-u300.dts | 2 +- > arch/arm/boot/dts/versatile-ab.dts | 2 +- > 23 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi > index ea288f0..8da4582 100644 > --- a/arch/arm/boot/dts/axm55xx.dtsi > +++ b/arch/arm/boot/dts/axm55xx.dtsi > @@ -107,7 +107,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus"; Actually, I would remove arm,amba-bus completely to prevent its spread. Both have been matched since ARM DT support began in the kernel. AFAICT, FreeBSD only uses simple-bus. If so, then this patch fixes FreeBSD on these systems (if that was the only issue). Rob ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-08 5:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 3:57 [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" compatible nodes Masahiro Yamada
2016-03-01 11:46 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Mark Rutland
2016-03-03 3:07 ` Masahiro Yamada
2016-03-03 10:12 ` [PATCH] ARM: dts: add "simple-bus" to "arm, amba-bus" " Jon Medhurst (Tixy)
[not found] ` <1456999975.2856.18.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-03 20:23 ` Rob Herring
2016-03-08 5:54 ` Masahiro Yamada
2016-03-03 20:44 ` [PATCH] ARM: dts: add "simple-bus" to "arm,amba-bus" " Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).