From: Shawn Guo <shawnguo@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Matt Mackall <mpm@selenic.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/3] ARM: i.MX25: add RNGC node to dtsi
Date: Tue, 1 Mar 2016 21:37:10 +0800 [thread overview]
Message-ID: <20160301133710.GV22051@tiger> (raw)
In-Reply-To: <1456761156-27664-2-git-send-email-s.trumtrar@pengutronix.de>
On Mon, Feb 29, 2016 at 04:52:35PM +0100, Steffen Trumtrar wrote:
> Add a devicetree entry for the Random Number Generator Version C (RNGC).
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> arch/arm/boot/dts/imx25.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index cde329e9b9e3..ec44ed125057 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -397,6 +397,15 @@
> interrupts = <41>;
> };
>
> + rng: rng@53fb0000 {
> + compatible = "fsl,imx25-rng";
> + reg = <0x53fb0000 0x4000>;
> + clocks = <&clks 109>;
> + clock-names = "ipg";
> + interrupts = <22>;
> + interrupt-names = "rng";
I do not see interrupt-names in the binding doc (patch #1). IMO, it
should be dropped.
Shawn
> + };
> +
> esdhc1: esdhc@53fb4000 {
> compatible = "fsl,imx25-esdhc";
> reg = <0x53fb4000 0x4000>;
> --
> 2.7.0
>
>
next prev parent reply other threads:[~2016-03-01 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 15:52 [PATCH 1/3] Documentation: devicetree: add Freescale RNGC binding Steffen Trumtrar
2016-02-29 15:52 ` [PATCH 2/3] ARM: i.MX25: add RNGC node to dtsi Steffen Trumtrar
2016-03-01 13:37 ` Shawn Guo [this message]
2016-02-29 15:52 ` [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC Steffen Trumtrar
2016-02-29 21:16 ` Fabio Estevam
2016-02-29 21:38 ` Uwe Kleine-König
[not found] ` <20160229213850.GS2613-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-29 23:54 ` Fabio Estevam
2016-03-01 7:49 ` Uwe Kleine-König
2016-03-07 13:03 ` Steffen Trumtrar
2016-03-03 23:56 ` [PATCH 1/3] Documentation: devicetree: add Freescale RNGC binding Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301133710.GV22051@tiger \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).