public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: devicetree@vger.kernel.org,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Kumar Gala <galak@codeaurora.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Lior Amsalem <alior@marvell.com>,
	Neta Zur Hershkovits <neta@marvell.com>,
	Yehuda Yitschak <yehuday@marvell.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: add SoC-specific compatible string to Marvell ODMI
Date: Wed, 2 Mar 2016 11:12:45 -0600	[thread overview]
Message-ID: <20160302171245.GA25012@rob-hp-laptop> (raw)
In-Reply-To: <1456327494-31358-1-git-send-email-thomas.petazzoni@free-electrons.com>

On Wed, Feb 24, 2016 at 04:24:54PM +0100, Thomas Petazzoni wrote:
> As requested by Rob Herring, this commit adds a SoC-specific
> compatible string to the Marvell ODMI DT binding.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> This commit applies on top of the Marvell ODMI driver patch, which has
> already been merged.
> ---
>  .../bindings/interrupt-controller/marvell,odmi-controller.txt      | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

I see this is already merged, but for the record:

Acked-by: Rob Herring <robh@kernel.org>

There is a typo in the example though.

> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/marvell,odmi-controller.txt b/Documentation/devicetree/bindings/interrupt-controller/marvell,odmi-controller.txt
> index 252d5c9..8af0a8e 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/marvell,odmi-controller.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,odmi-controller.txt
> @@ -6,7 +6,9 @@ which can be used by on-board peripheral for MSI interrupts.
>  
>  Required properties:
>  
> -- compatible           : The value here should contain "marvell,odmi-controller".
> +- compatible           : The value here should contain:
> +
> +    "marvell,ap806-odmi-controller", "marvell,odmi-controller".
>  
>  - interrupt,controller : Identifies the node as an interrupt controller.
>  
> @@ -29,7 +31,8 @@ Required properties:
>  Example:
>  
>  	odmi: odmi@300000 {
> -		compatible = "marvell,odmi-controller";
> +		compatible = "marvell,ap806-odm-controller",

s/odm/odmi/

> +			     "marvell,odmi-controller";
>  		interrupt-controller;
>  		msi-controller;
>  		marvell,odmi-frames = <4>;
> -- 
> 2.6.4
> 

      parent reply	other threads:[~2016-03-02 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 15:24 [PATCH] dt-bindings: interrupt-controller: add SoC-specific compatible string to Marvell ODMI Thomas Petazzoni
     [not found] ` <1456327494-31358-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-02-27 14:10   ` Jason Cooper
2016-03-02 17:12 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302171245.GA25012@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=nadavh@marvell.com \
    --cc=neta@marvell.com \
    --cc=pawel.moll@arm.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=yehuday@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox