Re: [PATCH 1/5 v7] dt/bindings: Add binding for the DA8xx MUSB driver

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Wed, Feb 24, 2016 at 04:26:13PM +0100, Petr Kulhavy wrote:
> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver.
> 
> Signed-off-by: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
> ---
> v1: <initial>
> 
> v2:
>  - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits"
>  - using "ti," prefix instead of "da8xx," for specific property names
>  - no wildcards in compatibility string
> 
> v3:
>  - added "reg", "interrupts" and "interrupt-names" properties
>  - wildcards in compatibility string
> 
> v4:
>  - compatibility string set to "ti,da830-musb"
>  - "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" properties removed and hardcoded
>  - "ti,phy20-clkmux-cfg" renamed to "ti,phy20-clkmux-pll" and changed to boolean
>  - removed "ti,hwmods"
> 
> v5:
>  - "ti,phy20-refclock-frequency" property made mandatory
> 
> v6:
>  - using "ti,usb2-phy-" prefix instead of "ti,phy20-" for the specific properties
> 
> v7:
>  - removed the "mentor,power" property; hard coded to 500mA in the code
> 
>  .../devicetree/bindings/usb/da8xx-usb.txt          | 43 ++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> new file mode 100644
> index 0000000..e281829
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
> @@ -0,0 +1,43 @@
> +TI DA8xx MUSB
> +~~~~~~~~~~~~~
> +For DA8xx/OMAP-L1x/AM17xx/AM18xx platforms.
> +
> +Required properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - compatible : Should be set to "ti,da830-musb".
> +
> + - reg: Offset and length of the USB controller register set.
> +
> + - interrupts: The USB interrupt number.
> +
> + - interrupt-names: Should be set to "mc".
> +
> + - dr_mode: The USB operation mode. Should be one of "host", "peripheral" or "otg".
> +
> + - ti,usb2-phy-refclock-frequency : Integer. Defines the USB 2.0 PHY reference clock input
> +     frequency in Hz in case the clock is generated by the internal PLL.
> +     Supported values are 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz

Shouldn't this be optional if it only applies for the internal PLL? I'd 
prefer "ti,usb2-phy-refclock-hz" so the units are clear.

> +Optional properties:
> +~~~~~~~~~~~~~~~~~~~~
> + - ti,usb2-phy-clkmux-pll: Boolean. Defines the USB 2.0 PHY reference clock source.
> +     If present the internal PLL is used as a clock source, otherwise the external
> +     USB_REFCLKIN pin is used.

External is the more common case? The property should be present for the 
less common case.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html