From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings Date: Thu, 3 Mar 2016 15:53:48 +0100 Message-ID: <20160303145348.GI15541@lunn.ch> References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457005210-18485-4-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1457005210-18485-4-git-send-email-narmstrong@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Neil Armstrong Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Mar 03, 2016 at 12:39:56PM +0100, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong > --- > .../bindings/interrupt-controller/plxtech,rps-irq.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt > new file mode 100644 > index 0000000..db117a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt ... > +- compatible: Should be "plxtech,nas782x-rps" Hi Neil It would be nice to be consistent with the naming. Maybe also the filename of the driver itself should be changed. You had an interesting sorting problem in the Makefile, which a consistent name would help with. Andrew