Re: [PATCH v5 3/4] ARM: dts: meson8b: Add MMC nodes

Carlo Caione
2016-05-11T18:05:02Z

On Wed, May 11, 2016 at 7:57 PM, Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> wrote:
> Hi Carlo,
>
> Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org> writes:
>
>> From: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
>>
>> Enable the MMC for the Meson8b platforms.
>>
>> Signed-off-by: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
>
> [...]
>
>> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
>> index 8bad557..25d795c 100644
>> --- a/arch/arm/boot/dts/meson8b.dtsi
>> +++ b/arch/arm/boot/dts/meson8b.dtsi
>> @@ -187,6 +187,22 @@
>> function = "uart_ao";
>> };
>> };
>> +
>> + mmc0_sd_b_pins: mmc0_sd_b {
>> + mux {
>> + groups = "sd_d1_b", "sd_d0_b", "sd_clk_b", "sd_cmd_b",
>> + "sd_d3_b", "sd_d2_b";
>> + function = "sd_b";
>> + };
>> + };
>
> These pins are added under pinctrl_aobus, but in the pinctrl driver,
> they're under cbus. If I move this into the pinctrl_cbus node, I get it
> to work on my odroid-c1, and am able to mount/use an MMC rootfs.

Ouch, thank you for pointing this out, I'll fix it in v6.

thanks,

--
Carlo Caione