From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Date: Fri, 4 Mar 2016 10:04:38 +0800 Message-ID: <20160304020438.GC30272@shlinux2.ap.freescale.net> References: <1456999276-6315-1-git-send-email-peter.chen@nxp.com> <1456999276-6315-4-git-send-email-peter.chen@nxp.com> <56D8BB1D.6040108@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56D8BB1D.6040108-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Maciej S. Szmigiero" Cc: Peter Chen , mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, Peter Chen , p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Mar 03, 2016 at 11:30:53PM +0100, Maciej S. Szmigiero wrote: > Hi Peter, > > On 03.03.2016 11:01, Peter Chen wrote: > > From: Peter Chen > > > > The current dts describes USB HUB's property at USB controller's > > entry, it is improper. The USB HUB should be the child node > > under USB controller. > > > > Signed-off-by: Peter Chen > > Thanks for patches! > > VID:PID for hub on UDOO board is 0424:2514. > > I've tested these patches on this board and was able to make USB work > again with following DT changes: > diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi > index d3e54e4..4956de7 100644 > --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi > @@ -9,6 +9,8 @@ > * > */ > > +#include > + > / { > chosen { > stdout-path = &uart2; > @@ -18,21 +27,11 @@ > reg = <0x10000000 0x40000000>; > }; > > - regulators { > - compatible = "simple-bus"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - reg_usb_h1_vbus: regulator@0 { > - compatible = "regulator-fixed"; > - reg = <0>; > - regulator-name = "usb_h1_vbus"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - enable-active-high; > - startup-delay-us = <2>; /* USB2415 requires a POR of 1 us minimum */ > - gpio = <&gpio7 12 0>; > - }; > + usb2415_pwrseq: usb2415_pwrseq { > + compatible = "usb-pwrseq"; > + clocks = <&clks IMX6QDL_CLK_CKO>; > + reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>; > + reset-duration-us = <3000>; > }; > > sound { > @@ -163,9 +218,16 @@ > &usbh1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usbh>; > - vbus-supply = <®_usb_h1_vbus>; > - clocks = <&clks 201>; > status = "okay"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub: usb2415@01 { > + compatible = "usb424,2514"; > + reg = <1>; > + usb-pwrseq = <&usb2415_pwrseq>; > + }; > }; > > &usdhc3 { > > Thank you very much. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html