From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/1] gpio: mcp23s08: Add support for mcp23s18. Date: Fri, 4 Mar 2016 22:24:52 -0600 Message-ID: <20160305042452.GA13525@rob-hp-laptop> References: <1456813541-74321-1-git-send-email-preid@electromag.com.au> <1456813541-74321-2-git-send-email-preid@electromag.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1456813541-74321-2-git-send-email-preid@electromag.com.au> Sender: linux-gpio-owner@vger.kernel.org To: Phil Reid Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Mar 01, 2016 at 02:25:41PM +0800, Phil Reid wrote: > This patch adds support for the mcp23s18 which is very similar to > the mcp23s17. A couple of control bits are not the same. > Notable IOCON_HAEN (s17 only) & IOCON_INTCC. Which can be ignored. > > Patch changes the following: > - Add mcp23s18 types. > - Always set mirror bit if the dts defines mcp23s18. regardless of type. > Mirror bit is ignored on 8 bit devices anyway. > - In mcp23s08_probe use chip.ngpio instead of logic based on type > to determine number of gpio lins to increment by. This is set > appropiately by the call to mcp23s08_probe_one. > - Add mcp23s18 to device tree documentation. > - Remove statement that irqs don't work for spi. They do. > Tested with mcp23s18. > > Signed-off-by: Phil Reid > --- > .../devicetree/bindings/gpio/gpio-mcp23s08.txt | 4 +--- Acked-by: Rob Herring