From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: Re: [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines Date: Sat, 5 Mar 2016 12:02:50 -0800 Message-ID: <20160305200250.GA24790@kroah.com> References: <1456592339-31767-1-git-send-email-hdegoede@redhat.com> <1456592339-31767-2-git-send-email-hdegoede@redhat.com> <20160304043559.GA21743@kroah.com> <56D938DE.10409@redhat.com> Reply-To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Content-Disposition: inline In-Reply-To: <56D938DE.10409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Philipp Zabel , Alan Stern , Tony Prisk , Florian Fainelli , Maxime Ripard , Arnd Bergmann , linux-usb , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , Reinder de Haan List-Id: devicetree@vger.kernel.org On Fri, Mar 04, 2016 at 08:27:26AM +0100, Hans de Goede wrote: > Hi, > > On 04-03-16 05:35, Greg Kroah-Hartman wrote: > >On Sat, Feb 27, 2016 at 05:58:58PM +0100, Hans de Goede wrote: > >>From: Reinder de Haan > >> > >>At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > >>reset lines, the controller will not initialize while the reset for > >>its companion is still asserted, which means we need to de-assert > >>2 resets for the controller to work. > >> > >>Signed-off-by: Reinder de Haan > >>Signed-off-by: Hans de Goede > >>Acked-by: Alan Stern > >>Acked-by: Rob Herring > >>--- > >>Changes in v2: > >>-Use the new reset_control_[de]assert_shared reset-controller functions > >>Changes in v3: > >>-Adjust for changes to shared-reset reset-controller functions > >>Changes in v4: > >>-Fix Ugly continuation line > > > >This breaks the build horribly :( > > > >As does patch 2/2, ugh. > > As said in the cover letter: > > "These patches apply on top of the related > reset-controller patches which have just been merged here: > > git://git.pengutronix.de/git/pza/linux.git reset/next" > > I guess I should have done s/apply on top of/depend on/ > in the above bit. These patches apply fine without those > changes, but indeed they will not build. Then I can't take them, you know this :( > You may want to ask Philipp Zabel (added to the To: list) > to create a topic branch for this which you can merge into > your tree. If you all want me to do that, fine, otherwise just resend them after 4.6-rc1 is out and the build will not break at that time. thanks, greg k-h