devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-pwm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] pwm: add DT bindings for the STMPE PWM
Date: Mon, 7 Mar 2016 10:26:41 +0100	[thread overview]
Message-ID: <20160307092641.GG31189@ulmo.nvidia.com> (raw)
In-Reply-To: <1455455317-17043-1-git-send-email-linus.walleij@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On Sun, Feb 14, 2016 at 02:08:37PM +0100, Linus Walleij wrote:
> This adds fairly standard device tree bindings for the STMPE
> PWM found in STMPE24xx multi-purpose expanders.
> 
> Cc: devicetree@vger.kernel.org
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> 
> diff --git a/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> new file mode 100644
> index 000000000000..c8b53f39ae31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/st,stmpe-pwm.txt
> @@ -0,0 +1,18 @@
> +== ST STMPE PWM controller ==
> +
> +This is a PWM block embedded in the ST Microelectronics STMPE
> +(ST Multi-Purpose Expander) chips. The PWM is registered as a
> +subdevices of the STMPE MFD device.
> +
> +Required properties:
> +- compatible: should be:
> +  - "st,stmpe-pwm"
> +- #pwm-cells: should be 2. See pwm.txt in this directory for a description of
> +  the cells format.
> +
> +Example:
> +
> +stmpe1_pwm0: stmpe_pwm {

Shouldn't the node name simply be "pwm"? stmpe_pwm is kind of redundant
given that this is to be embedded in an MFD node that will, presumably,
be called stmpe.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2016-03-07  9:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14 13:08 [PATCH 1/2] pwm: add DT bindings for the STMPE PWM Linus Walleij
2016-03-07  9:26 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307092641.GG31189@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-pwm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).