From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Niklas =?iso-8859-1?Q?S=F6derlund?=" Subject: Re: [PATCH 00/30] ARM: dts: r8a779[0-4]: Reference both DMA controllers Date: Thu, 10 Mar 2016 14:43:25 +0100 Message-ID: <20160310134325.GA1111@bigcity.dyn.berto.se> References: <1457609782-24108-1-git-send-email-niklas.soderlund+renesas@ragnatech.se> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Laurent Pinchart , linux-renesas-soc@vger.kernel.org, "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hi Geert, On 2016-03-10 13:20:56 +0100, Geert Uytterhoeven wrote: > Hi Niklas, >=20 > On Thu, Mar 10, 2016 at 12:35 PM, Niklas S=F6derlund > wrote: > > R-Car Gen2 have two DMA controllers, which are equivalent. However = DMA > > slaves were tied only to a single DMA controller in .dtsi. This ser= ies > > add references to to both DMA controllers for all nodes that previo= usly > > only referenced one of them. It also adds dma references to the SDH= I > > nodes for r8a7794 which according to the datasheet should work but = I > > have not access to HW to verify. > > > > Tested on Koelsch (r8a7791) by altering the compatible value of eit= her > > dmac0 or dmac1 and verifying that the DMA slaves pick the DMA contr= oller > > that is instantiated. >=20 > Thanks for your series! >=20 > If you fix the subject of patch 30: > Acked-by: Geert Uytterhoeven Thanks for your review and that you found my error in the subject. >=20 > I guess this is against v4.5-rc7? It doesn't apply against > renesas-devel-20160308-v4.5-rc7. > Unfortunately you'll have to rebase against Simon's tree, and add sci= f2 > on r8a7790, and i2c[6-8] on r8a7793. I will rebase and update the relevant patches to include the additions=20 to r8a7790 and r8a7793. >=20 > Hint for the other reviewers: use the --color-words option of git dif= f/show. >=20 > Gr{oetje,eeting}s, >=20 > Geert >=20 > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linu= x-m68k.org >=20 > In personal conversations with technical people, I call myself a hack= er. But > when I'm talking to journalists I just say "programmer" or something = like that. > -- Linus Torvalds --=20 Regards, Niklas S=F6derlund