From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: of/fdt: move memreserve and dtb memory reservations into core
Date: Fri, 11 Mar 2016 11:48:43 +0300 [thread overview]
Message-ID: <20160311084843.GA6181@mwanda> (raw)
Hello Rob Herring,
The patch d1552ce449eb: "of/fdt: move memreserve and dtb memory
reservations into core" from Apr 1, 2014, leads to the following
static checker warning:
drivers/of/fdt.c:594 early_init_fdt_scan_reserved_mem()
error: potentially using uninitialized 'size'.
drivers/of/fdt.c
583 void __init early_init_fdt_scan_reserved_mem(void)
584 {
585 int n;
586 u64 base, size;
^^^^
587
588 if (!initial_boot_params)
589 return;
590
591 /* Process header /memreserve/ fields */
592 for (n = 0; ; n++) {
593 fdt_get_mem_rsv(initial_boot_params, n, &base, &size);
^^^^
594 if (!size)
^^^^
Presumably we don't care about errors during boot because it's doomed
anyway, but we might want to silence the warning?
595 break;
596 early_init_dt_reserve_memory_arch(base, size, 0);
597 }
598
599 of_scan_flat_dt(__fdt_scan_reserved_mem, NULL);
600 fdt_init_reserved_mem();
601 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2016-03-11 8:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311084843.GA6181@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).