From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Subject: Re: [PATCHv4 2/2] bindings: spi: Add clock entries for spi-xilinx Date: Sat, 12 Mar 2016 02:05:18 -0800 Message-ID: <20160312100518.GT3173@xsjsorenbubuntu> References: <1457769637-5627-1-git-send-email-shubhraj@xilinx.com> <1457769637-5627-2-git-send-email-shubhraj@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1457769637-5627-2-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shubhrajyoti Datta Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, Shubhrajyoti Datta List-Id: devicetree@vger.kernel.org On Sat, 2016-03-12 at 13:30:37 +0530, Shubhrajyoti Datta wrote: > Add clock description for spi-xilinx >=20 > Signed-off-by: Shubhrajyoti Datta > --- > v3 > Add a clock name > v4 > Correct the name=20 > .../devicetree/bindings/spi/spi-xilinx.txt | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/spi/spi-xilinx.txt b/D= ocumentation/devicetree/bindings/spi/spi-xilinx.txt > index c7b7856..07ec09a 100644 > --- a/Documentation/devicetree/bindings/spi/spi-xilinx.txt > +++ b/Documentation/devicetree/bindings/spi/spi-xilinx.txt > @@ -7,6 +7,9 @@ Required properties: > - interrupts : Property with a value describing the interrupt > number. > - interrupt-parent : Must be core interrupt controller > +- clocks: Input clock specifier. Refer to common clock bindings. > +- clock-names: tuple listing input clock names. > + Required elements: "s_axi_aclk" I thought there were too clocks? If the IP has two clocks, I think both should be added and supported here. > =20 > Optional properties: > - xlnx,num-ss-bits : Number of chip selects used. > @@ -14,6 +17,8 @@ Optional properties: > Example: > axi_quad_spi@41e00000 { > compatible =3D "xlnx,xps-spi-2.00.a"; > + clocks =3D <&clkc 15>; > + clock-names =3D "spi_fclk"; Doesn't match the binding documented above. S=C3=B6ren -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html