From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] pinctrl: sunxi: Fix A33 external interrupts not working Date: Sun, 13 Mar 2016 18:02:54 +0100 Message-ID: <20160313170254.GF8418@lukather> References: <1457808297-12300-1-git-send-email-hdegoede@redhat.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ckw48dMXwVCm+GhK" Return-path: Content-Disposition: inline In-Reply-To: <1457808297-12300-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Chen-Yu Tsai , Linus Walleij , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --ckw48dMXwVCm+GhK Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Sat, Mar 12, 2016 at 07:44:57PM +0100, Hans de Goede wrote: > pinctrl-sun8i-a33.c (and the dts) declare only 2 interrupt banks, > where as the closely related a23 has 3 banks. This matches with the > datasheet for the A33 where only interrupt banks B and G are specified > where as the A23 has banks A, B and G. > > However the A33 being the A23 derative it is means that the interrupt > configure/status io-addresses for the 2 banks it has are not changed > from the A23, iow they have the same address as if bank A was still > present. Where as the sunxi pinctrl currently tries to use the A23 bank > A addresses for bank B, since the pinctrl code does not know about the > removed bank A. > > Add a irq_bank_base parameter and use this where appropriate to take > the missing bank A into account. > > This fixes external interrupts not working on the A33 (tested with > an i2c touchscreen controller which uses an external interrupt). > > Signed-off-by: Hans de Goede Acked-by: Maxime Ripard You should send it to stable though. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ckw48dMXwVCm+GhK--