From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Date: Mon, 14 Mar 2016 11:52:08 +0100 Message-ID: <20160314105208.GM8418@lukather> References: <1457192586-25596-1-git-send-email-vishnupatekar0510@gmail.com> <1457192586-25596-2-git-send-email-vishnupatekar0510@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BDCv8JNaL8ltm7rS" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Vishnu Patekar Cc: Linus Walleij , Rob Herring , Jon Corbet , =?utf-8?B?UGF3ZcWC?= Moll , Mark Rutland , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Kumar Gala , Russell King - ARM Linux , Emilio Lopez , Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michael Turquette , Stephen Boyd , Reinder List-Id: devicetree@vger.kernel.org --BDCv8JNaL8ltm7rS Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Sat, Mar 12, 2016 at 12:48:02PM +0800, Vishnu Patekar wrote: > Hello Linus, > > > On Wed, Mar 9, 2016 at 10:55 AM, Linus Walleij wrote: > > On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar > > wrote: > > > >> The A83T has R_PIO pin controller, it's same as A23, execpt A83T > >> interrupt bit is 6th and A83T has one extra pin PL12. > >> > >> Signed-off-by: Vishnu Patekar > >> Acked-by: Chen-Yu Tsai > >> Acked-by: Rob Herring > > > > As partly noted by others: > > > >> +config PINCTRL_SUN8I_A83T_R > >> + def_bool MACH_SUN8I > > > > bool > > > >> + depends on RESET_CONTROLLER > > > > Should it rather select RESET_CONTROLLER? > I used depends on and def_bool as it is used for other sunxi pinctrl drivers. > Using bool and select will not harm anything. It will, at least in the case of def_bool, since that symbol will not be enabled by default, and you'll have no way to enable it. And RESET_CONTROLLER is a bit messy, since you can't just select it because it also has a dependency on an ARCH_HAS_RESET_CONTROLLER symbol. > Should I change it to bool and select ? or keep it to be uniform with > earlier options? Please keep it that way. Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --BDCv8JNaL8ltm7rS--