From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Sergei Ianovich <ynvich@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alessandro Zummo <a.zummo@towertech.it>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:REAL TIME CLOCK RTC SUBSYSTEM"
<rtc-linux@googlegroups.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v7] rtc: rewrite DS1302 using SPI
Date: Tue, 15 Mar 2016 01:18:44 +0100 [thread overview]
Message-ID: <20160315001844.GJ28277@piout.net> (raw)
In-Reply-To: <1456224900-4877-1-git-send-email-ynvich@gmail.com>
Hi,
Thank you for your work!
On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote :
> -#ifdef CONFIG_SH_SECUREEDGE5410
> -#include <asm/rtc.h>
> -#include <mach/secureedge5410.h>
> -
> -#define RTC_RESET 0x1000
> -#define RTC_IODATA 0x0800
> -#define RTC_SCLK 0x0400
> -
> -#define set_dp(x) SECUREEDGE_WRITE_IOPORT(x, 0x1c00)
> -#define get_dp() SECUREEDGE_READ_IOPORT()
> -#define ds1302_set_tx()
> -#define ds1302_set_rx()
> -
I would like to have a solution for secureedge5410 even if it is
untested. Else, we are breaking an existing platform without any
solution.
I've put the sh maintainers in copy, maybe they have an opinion. Else
I'll let your patch sit in linux-next for the next cycle.
I have further cleanups in that driver but they can probably be done
later.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-15 0:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <397668667-27328-3-git-send-email-ynvich@gmail.com>
2015-12-15 17:45 ` [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Sergei Ianovich
2015-12-20 3:38 ` Rob Herring
2015-12-20 12:14 ` Sergei Ianovich
2015-12-22 18:16 ` Rob Herring
[not found] ` <CAL_JsqKxEkuvQ=7=zmb0pkNNyUe9aKzKics43QasUBDM2rmrwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-24 11:04 ` Alexandre Belloni
2015-12-24 11:07 ` Sergei Ianovich
2016-02-22 1:41 ` [PATCH v6] rtc: rewrite DS1302 using SPI Sergei Ianovich
[not found] ` <1456105286-28598-1-git-send-email-ynvich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-22 18:45 ` Rob Herring
2016-02-23 10:54 ` [PATCH v7] " Sergei Ianovich
2016-03-15 0:18 ` Alexandre Belloni [this message]
2016-03-18 10:38 ` Sergei Ianovich
[not found] ` <1456224900-4877-1-git-send-email-ynvich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-23 23:29 ` Rob Herring
2016-03-28 20:57 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315001844.GJ28277@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dalias@libc.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=ynvich@gmail.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).