From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v7] rtc: rewrite DS1302 using SPI Date: Tue, 15 Mar 2016 01:18:44 +0100 Message-ID: <20160315001844.GJ28277@piout.net> References: <1456105286-28598-1-git-send-email-ynvich@gmail.com> <1456224900-4877-1-git-send-email-ynvich@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1456224900-4877-1-git-send-email-ynvich@gmail.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Ianovich , Yoshinori Sato , Rich Felker Cc: linux-kernel@vger.kernel.org, Rob Herring , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK RTC SUBSYSTEM" , linux-sh@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, Thank you for your work! On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote : > -#ifdef CONFIG_SH_SECUREEDGE5410 > -#include > -#include > - > -#define RTC_RESET 0x1000 > -#define RTC_IODATA 0x0800 > -#define RTC_SCLK 0x0400 > - > -#define set_dp(x) SECUREEDGE_WRITE_IOPORT(x, 0x1c00) > -#define get_dp() SECUREEDGE_READ_IOPORT() > -#define ds1302_set_tx() > -#define ds1302_set_rx() > - I would like to have a solution for secureedge5410 even if it is untested. Else, we are breaking an existing platform without any solution. I've put the sh maintainers in copy, maybe they have an opinion. Else I'll let your patch sit in linux-next for the next cycle. I have further cleanups in that driver but they can probably be done later. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com