Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

Stephen Warren
2016-03-16T17:59:44Z

On 03/04/2016 09:19 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Extend the binding to cover the set of feature found in Tegra210.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

> diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt

> + padctl@0,7009f000 {
...
> + pads {
...
> + };
> +
> + ports {
...
> + };

As a comment not affecting my ack in any way: At the top-level, we place
all the child nodes into "array container" nodes named "pads" and
"ports". This is nice since it separates different types of child nodes
and allows easily adding more types of child nodes in the future without
interference, and in a way that allows us to explicitly know what each
node is without having to interpret its name or compatible value to do
so. However, we haven't done this with the per-lane child nodes inside
each pad. If we were to rev the design, I'd be tempted to suggest:

padctl@0,7009f000 {
pads {
usb2 {
lanes { // This level is new
usb2-0 {